-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confused about scrub frequency #34
Comments
I noticed that scrub will only run if there are change in array, and will only scrub after sync completed. According documents from snapraid, the scrub job should run every week at least even there are nothing change in array to proect data from damaged(particularly silent error), and only scrub in synced array. That's means we should run scrub jobs even there are nothing change in array if it's a synced array. I am also going to implemet this in scripts and submit to previous pull request. |
Scrub absolutely needs to be run regularly even if there has been no change, but if there has been changes but it's below the threshold set for a sync, then a scrub won't have the information for the current data and it could end up trying to fix something that was changed. I think that the script should be changed to run a sync after a predetermined time regardless if there are no, or so few changes that it didn't trigger a sync earlier. That way you can make sure the scrub is run regularly sync data that reflects the current state of the disk. |
Hi, But according to the author's' suggestion, we may find another volunteer who is also using SnapRaid to test it and ensure everything works as expected. So, @thenebular could you have a test? The usage is simple, just disable cron of old version, and upload the new version to anywhere you want, just remember to give it execute permission. Then add scripts to cron according to your settings. And we may go on to that PR. Scripts action that I implemented currently just for your reference.
|
Closing due to age. |
Hi,
The scrub settings in omv are described as "scrub frequency's unit is day", which means it will determined how many days when it executed.
But according code, the currently implements add scrub counter one by one when execute. Code here.
So with default settings, system executes omv-snapraid-diff every week, and scrub counter target is set to 7, in this situation it will only scrub every 7 * 7 = 49 days.
But if change settings to run this script every days, it will scrub array every 7days.
The describe here is a bit confused, so i will suggest to change description or reimplement this feature to fit it claimed currently.
I think we can reocrd last date that the scripts scubed, and use current date to compared with it to determin if should scrub again.
The text was updated successfully, but these errors were encountered: