From 12c0bbe81d36db952da362156e8ad498b3c8fd73 Mon Sep 17 00:00:00 2001 From: teo Date: Wed, 19 Jun 2024 15:00:14 +0300 Subject: [PATCH 1/2] added status message to err --- .../syft/src/syft/service/code/user_code_service.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/syft/src/syft/service/code/user_code_service.py b/packages/syft/src/syft/service/code/user_code_service.py index 9287e49fec4..9302dd37404 100644 --- a/packages/syft/src/syft/service/code/user_code_service.py +++ b/packages/syft/src/syft/service/code/user_code_service.py @@ -519,10 +519,12 @@ def _call( if not can_execute: # We check output policy only in l2 deployment. # code is from low side (L0 setup) - if not code.is_output_policy_approved(context): - return Err( - "Execution denied: Your code is waiting for approval" - ) + status = code.get_status(context) + if not status.approved: + # return Err( + # "Execution denied: Your code is waiting for approval" + # ) + return Err(status.get_status_message().message) is_valid = ( output_policy._is_valid(context) if output_policy else False ) From 843e283f272d1a401b636fd44635ce962a7299f4 Mon Sep 17 00:00:00 2001 From: Koen van der Veen Date: Thu, 20 Jun 2024 10:05:24 +0200 Subject: [PATCH 2/2] update test --- .../syft/tests/syft/request/request_code_accept_deny_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/syft/tests/syft/request/request_code_accept_deny_test.py b/packages/syft/tests/syft/request/request_code_accept_deny_test.py index cef84e4d2d1..b21a06579d1 100644 --- a/packages/syft/tests/syft/request/request_code_accept_deny_test.py +++ b/packages/syft/tests/syft/request/request_code_accept_deny_test.py @@ -202,4 +202,4 @@ def simple_function(data): result = ds_client.code.simple_function(data=action_obj) assert isinstance(result, SyftError) - assert "Execution denied" in result.message + assert "DENIED" in result.message