Skip to content

Commit

Permalink
[CI] fix the ORCHESTRA_DEPLOYMENT_TYPE env variable set to wrong value
Browse files Browse the repository at this point in the history
  • Loading branch information
khoaguin committed Sep 30, 2024
1 parent 40c9387 commit 6cdd3d6
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 7 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/pr-tests-stack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1055,8 +1055,6 @@ jobs:
- name: Run scenario tests
if: steps.changes.outputs.syft == 'true' || steps.changes.outputs.notebooks_scenario == 'true'
env:
ORCHESTRA_DEPLOYMENT_TYPE: "${{ matrix.deployment-type }}"
BUMP_VERSION: "${{ matrix.bump-version }}"
TOX_PYTHON: python${{ matrix.python-version }}
shell: bash
run: |
Expand Down Expand Up @@ -1181,7 +1179,6 @@ jobs:
- name: Run scenario tests
if: steps.changes.outputs.syft == 'true' || steps.changes.outputs.notebooks_scenario == 'true'
env:
ORCHESTRA_DEPLOYMENT_TYPE: "${{ matrix.deployment-type }}"
BUMP_VERSION: "${{ matrix.bump-version }}"
TOX_PYTHON: python${{ matrix.python-version }}
shell: bash
Expand Down
7 changes: 6 additions & 1 deletion notebooks/api/0.8/11-container-images-k8s.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1394,6 +1394,11 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -1404,7 +1409,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.5"
"version": "3.12.2"
}
},
"nbformat": 4,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.13"
"version": "3.12.2"
}
},
"nbformat": 4,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.13"
"version": "3.12.2"
}
},
"nbformat": 4,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.13"
"version": "3.12.2"
}
},
"nbformat": 4,
Expand Down
29 changes: 29 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ envlist =
syft.test.security
syft.test.unit
syft.test.scenario
syft.test.scenario.sync
syft.test.notebook
syft.test.notebook.scenario
syft.test.notebook.scenario.sync
Expand Down Expand Up @@ -293,6 +294,32 @@ commands =
bash -c 'ulimit -n 4096 || true'
pytest -n auto --dist loadgroup --durations=20 --disable-warnings

[testenv:syft.test.scenario]
description = BigQuery Scenario Tests on Python Servers (L2)
changedir = {toxinidir}
deps =
{[testenv:syft]deps}
pytest-asyncio
pytest-timeout
allowlist_externals =
bash
pytest
commands =
bash -c "pytest -s --disable-warnings tests/scenariosv2/l2_test.py"

[testenv:syft.test.scenario.sync]
description = BigQuery Scenario Tests on Python Servers (L0)
changedir = {toxinidir}
deps =
{[testenv:syft]deps}
pytest-asyncio
pytest-timeout
allowlist_externals =
bash
pytest
commands =
bash -c "pytest -s --disable-warnings tests/scenariosv2/l0_test.py"

[testenv:stack.test.scenario.k8s]
description = BigQuery Scenario Tests on K8s (L2)
changedir = {toxinidir}
Expand All @@ -309,6 +336,7 @@ allowlist_externals =
commands_pre =
just delete-all start-high deploy-high wait-high
commands =
bash -c "echo Running BigQuery Scenario Tests on K8s (L2) with ORCHESTRA_DEPLOYMENT_TYPE=$ORCHESTRA_DEPLOYMENT_TYPE"
bash -c "pytest -s --disable-warnings tests/scenariosv2/l2_test.py"
commands_post =
just delete-all
Expand All @@ -330,6 +358,7 @@ commands_pre =
just delete-all start-high deploy-high wait-high
just start-low deploy-low wait-low
commands =
bash -c "echo Running BigQuery Scenario Tests on K8s (L0) with ORCHESTRA_DEPLOYMENT_TYPE=$ORCHESTRA_DEPLOYMENT_TYPE"
bash -c "pytest -s --disable-warnings tests/scenariosv2/l0_test.py"
commands_post =
just delete-all
Expand Down

0 comments on commit 6cdd3d6

Please sign in to comment.