Merge pull request #8219 from OpenMined/set-defaults

Add defaults to NodeMetadataJSON
OpenMined · Nov 2, 2023 · c6fc846 · c6fc846
2 parents 390a890 + 11b89d8
commit c6fc846
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/syft/src/syft/service/metadata/node_metadata.py b/packages/syft/src/syft/service/metadata/node_metadata.py
@@ -79,8 +79,8 @@ class NodeMetadata(SyftObject):
     organization: str = "OpenMined"
     on_board: bool = False
     description: str = "Text"
-    signup_enabled: bool = False
-    admin_email: str = ""
+    signup_enabled: bool
+    admin_email: str
     node_side_type: str
     show_warnings: bool
 
@@ -158,8 +158,8 @@ class NodeMetadataJSON(BaseModel, StorableObjectType):
     node_type: str = NodeType.DOMAIN.value
     organization: str = "OpenMined"
     description: str = "My cool domain"
-    signup_enabled: Optional[bool]
-    admin_email: Optional[str]
+    signup_enabled: bool = False
+    admin_email: str = ""
     node_side_type: str
     show_warnings: bool
     supported_protocols: List = []