Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behavior when GitHub API is down #80

Open
jesse-gallagher opened this issue May 29, 2021 · 0 comments
Open

Improve behavior when GitHub API is down #80

jesse-gallagher opened this issue May 29, 2021 · 0 comments
Labels
domino enhancement New feature or request

Comments

@jesse-gallagher
Copy link
Member

When GitHub's API is unavailable, automatic JVM download will fail. That's not terribly unexpected, but the exception bubbles all the way to to top and stops subsequent servers from starting. It'd be better to catch most exceptions when sending commands to init servers and continue on to the rest.

SEVERE Encountered unexpected exception 
java.io.UncheckedIOException: java.io.IOException: Received unexpected response code 503 from URL https://api.github.com/repos/AdoptOpenJDK/openjdk11-binaries/releases?per_page=100 
 at org.openntf.openliberty.domino.jvm.AbstractDownloadingJavaRuntimeProvider.fetchGitHubReleasesList(AbstractDownloadingJavaRuntimeProvider.java:65) 
 at org.openntf.openliberty.domino.jvm.AdoptOpenJDKJavaRuntimeProvider.getJavaHome(AdoptOpenJDKJavaRuntimeProvider.java:90) 
 at org.openntf.openliberty.domino.server.AbstractJavaServerInstance.lambda$getJavaHome$2(AbstractJavaServerInstance.java:45) 
 at org.openntf.openliberty.domino.server.AbstractJavaServerInstance$$Lambda$28/0x0000000044069d00.apply(Unknown Source) 
 at java.util.HashMap.computeIfAbsent(HashMap.java:1127) 
 at java.util.Collections$SynchronizedMap.computeIfAbsent(Collections.java:2674) 
 at org.openntf.openliberty.domino.server.AbstractJavaServerInstance.getJavaHome(AbstractJavaServerInstance.java:39) 
 at org.openntf.openliberty.domino.server.LibertyServerInstance.deploy(LibertyServerInstance.java:126) 
 at org.openntf.openliberty.domino.runtime.OpenLibertyRuntime.run(OpenLibertyRuntime.java:109) 
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
 at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
 at lotus.domino.NotesThread.run(Unknown Source) 
Caused by: java.io.IOException: Received unexpected response code 503 from URL https://api.github.com/repos/AdoptOpenJDK/openjdk11-binaries/releases?per_page=100 
 at org.openntf.openliberty.domino.util.OpenLibertyUtil.download(OpenLibertyUtil.java:100) 
 at org.openntf.openliberty.domino.jvm.AbstractDownloadingJavaRuntimeProvider.fetchGitHubReleasesList(AbstractDownloadingJavaRuntimeProvider.java:57) 
 ... 13 more 
INFO Shutting down server mainServer 
SEVERE Exception while terminating server mainServer 
INFO Shutdown  
@jesse-gallagher jesse-gallagher added enhancement New feature or request domino labels May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domino enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant