From aac309036ef77fe86bf65e9a119978e68470186b Mon Sep 17 00:00:00 2001 From: Rudra Pratap Singh Date: Sun, 15 Dec 2024 22:17:50 +0530 Subject: [PATCH] [Fixes] `registry-actions.yml` workflow (#31) * Corrected rock path in `registry-actions.yml` & correct env variable (PORT) passed instructions in README * Fixes typo --- .github/workflows/registry-actions.yml | 2 -- README.md | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/registry-actions.yml b/.github/workflows/registry-actions.yml index b01d43a..46052c1 100644 --- a/.github/workflows/registry-actions.yml +++ b/.github/workflows/registry-actions.yml @@ -31,8 +31,6 @@ jobs: - name: Pack with Rockcraft uses: canonical/craft-actions/rockcraft-pack@main id: rockcraft - with: - path: rock - name: Upload Rock Artifact uses: actions/upload-artifact@v4 diff --git a/README.md b/README.md index 30a80c2..1b01f18 100644 --- a/README.md +++ b/README.md @@ -313,12 +313,12 @@ Then run the following Docker command to run the ps-printer-app image in a conta sudo docker run --rm -d \ --name ps-printer-app \ --network host \ - -e PORT: \ + -e PORT= \ openprinting/ps-printer-app:latest ``` - `PORT` is an optional environment variable used to start the printer-app on a specified port. If not provided, it will start on the default port 8000 or, if port 8000 is busy, on 8001 and so on. - **The container must be started in `--network host` mode** to allow the Printer-Application instance inside the container to access and discover printers available in the local network where the host system is in. -- Alternatively using the internal network of the Docker instance (`-p :8000` instead of `--network host -e PORT:`) only gives access to local printers running on the host system itself. +- Alternatively using the internal network of the Docker instance (`-p :8000` instead of `--network host -e PORT=`) only gives access to local printers running on the host system itself. ### Setting up and running a ps-printer-app container locally @@ -360,12 +360,12 @@ sudo rockcraft.skopeo --insecure-policy copy oci-archive: docker-dae sudo docker run --rm -d \ --name ps-printer-app \ --network host \ - -e PORT: \ + -e PORT= \ ps-printer-app:latest ``` - `PORT` is an optional environment variable used to start the printer-app on a specified port. If not provided, it will start on the default port 8000 or, if port 8000 is busy, on 8001 and so on. - **The container must be started in `--network host` mode** to allow the Printer-Application instance inside the container to access and discover printers available in the local network where the host system is in. -- Alternatively using the internal network of the Docker instance (`-p :8000` instead of `--network host -e PORT:`) only gives access to local printers running on the host system itself. +- Alternatively using the internal network of the Docker instance (`-p :8000` instead of `--network host -e PORT=`) only gives access to local printers running on the host system itself. #### Setting up