Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add etcs LOA and SVL logic #10316

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

core: add etcs LOA and SVL logic #10316

wants to merge 1 commit into from
+269 −3

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Jan 10, 2025 •
edited
Loading

What's left to do:

  • compute ebi from ebd: LOA case: maintain non null target speed until target position
  • SVL case: compute the minimum between IndicationSvl and IndicationEoa, then maintain speed at dvWarning (4km/h, is minSpeed), then follow indicationEoa, which ends at Eoa, which is the target position (or see how to implement release speed?)
    - compute the minimum envelope between the brakingEnvelopeLOA and brakingEnvelopeEOA (or maybe unneeded and change interface to allow both to be computed one after the other, works as well)

@github-actions github-actions bot added the area:core Work on Core Service label Jan 10, 2025
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch from b0ec3e8 to ba9f038 Compare January 10, 2025 10:24
@Erashin Erashin changed the base branch from dev to alch/core/etcs_use_physics_path January 10, 2025 10:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (675d279) to head (1998907).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10316      +/-   ##
==========================================
- Coverage   81.64%   81.59%   -0.06%     
==========================================
  Files        1066     1067       +1     
  Lines      105735   105535     -200     
  Branches      727      727              
==========================================
- Hits        86328    86109     -219     
- Misses      19366    19385      +19     
  Partials       41       41
Flag Coverage Δ
editoast 73.62% <ø> (-0.07%) ⬇️
front 89.30% <ø> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/core/etcs_use_physics_path branch from cb6893a to bbbd885 Compare January 10, 2025 17:15
@Erashin Erashin linked an issue Jan 13, 2025 that may be closed by this pull request
core: ETCS: implement LOA and SVL braking curves logic #10330
Open
@Erashin Erashin force-pushed the alch/core/etcs_use_physics_path branch from bbbd885 to 6d85230 Compare January 13, 2025 09:29
@Erashin Erashin mentioned this pull request Jan 13, 2025
Merged
@Erashin Erashin force-pushed the alch/core/etcs_use_physics_path branch 9 times, most recently from 41c408e to dff72ae Compare January 15, 2025 08:29
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch 2 times, most recently from 7e31c30 to bbbab6f Compare January 15, 2025 09:28
@Erashin Erashin force-pushed the alch/core/etcs_use_physics_path branch from dff72ae to 6fe9bff Compare January 15, 2025 09:34
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch 2 times, most recently from f0eed6e to 556d53d Compare January 15, 2025 09:59
@Erashin Erashin force-pushed the alch/core/etcs_use_physics_path branch 2 times, most recently from 3adb1dc to 61f6cc8 Compare January 15, 2025 10:43
Base automatically changed from alch/core/etcs_use_physics_path to dev January 15, 2025 11:21
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch from 556d53d to f5c6549 Compare January 15, 2025 13:07
@Erashin Erashin force-pushed the alch/core/add_loa_svl_etcs_logic branch from f5c6549 to 1998907 Compare January 15, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:core Work on Core Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: ETCS: implement LOA and SVL braking curves logic
2 participants
@Erashin @codecov-commenter