Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to add waypoints when rapidly clicking on the '+' buttons #8958

Closed
Maymanaf opened this issue Sep 23, 2024 · 3 comments
Closed

Fails to add waypoints when rapidly clicking on the '+' buttons #8958

Maymanaf opened this issue Sep 23, 2024 · 3 comments
Assignees
@Maymanaf
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug

Comments

@Maymanaf
Copy link
Contributor

What happened?

When clicking on both 'Add this waypoint' + buttons only one waypoint is added :

Fails.to.add.waypoints.when.rapidly.clicking.add.icons.mp4

What did you expect to happen?

Both Waypoints are added when click on '+' buttons

How can we reproduce it (as minimally and precisely as possible)?

  1. Click on Add waypoints
  2. Click rapidly on 'Add this waypoint +' buttons

On which environments the bug occurs?

Local, Dev (SNCF), Recette (SNCF)

On which browser the bug occurs?

Firefox, Google Chrome

OSRD version (top right corner Account button > Informations)

fbf8e3e
@Maymanaf Maymanaf added kind:bug Something isn't working severity:minor Minor severity bug area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Sep 23, 2024
@woshilapin
Copy link
Contributor

Also note that when this bug will be fixed, we'll need to remove a TODO in the code (see #8913).

@clarani clarani self-assigned this Jan 2, 2025
@clarani
Copy link
Contributor

clarani commented Jan 2, 2025

I think this bug was solved by #9924 and #9901.

Can you update your tests @Maymanaf ?

@clarani clarani assigned Maymanaf and unassigned clarani Jan 2, 2025
@Maymanaf
Copy link
Contributor Author

This bug is fixed , I will update the e2e tests in this ticket : #10321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maymanaf Maymanaf

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@woshilapin @Maymanaf @clarani