Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SBB header #9269

Closed
5 tasks
louisgreiner opened this issue Oct 9, 2024 · 1 comment
Closed
5 tasks

Remove SBB header #9269

louisgreiner opened this issue Oct 9, 2024 · 1 comment
Labels
area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module kind:enhancement Improvement of existing features module:operational-studies Multi-train simulation with structured studies management

Comments

@louisgreiner
Copy link
Contributor

louisgreiner commented Oct 9, 2024 •
edited
Loading

Description

Enabled by Synchronize OSRD/NGE locale #8569, since the current header is the only way to change locale in NGE.

We want to remove this header band, highlighted in yellow:

Image

This feature has to be done on our forked repository : https://github.com/osrd-project/netzgrafik-editor-frontend

Note : to work with the forked repo, to keep it clean, thanks for following the guidelines in README

Acceptance criteria

  • The header is not visible anymore
  • Changes have been made only on the forked repository (/!\ clean commit message + follow README)
  • The size of the iframe has been recalculated taking in account the size saving (no scroll bar or empty space, follow the mock-up)

Implementation plan

  • Create branch on forked repo
  • Remove header with minimal changes
  • Commit with message "hack: remove sbb header"
  • Merge new branch -> standalone
  • Bump package version (see npm version) in OSRD
@louisgreiner louisgreiner added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management component:nge Macroscopic mode of Operational Studies module labels Oct 9, 2024
@clarani
Copy link
Contributor

clarani commented Nov 26, 2024

Closed by #9760

@clarani clarani closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module kind:enhancement Improvement of existing features module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clarani @louisgreiner