Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the position of variables #1525

Closed
Thorlogy opened this issue Jun 12, 2023 · 4 comments
Closed

Moving the position of variables #1525

Thorlogy opened this issue Jun 12, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Thorlogy
Copy link

Is your feature request related to a problem? Please describe.
-Currently, the position of an initialised variable is fixed. It would be nice to be able to change the position of variables within the start block. This would bring more clarity.

Describe the solution you'd like

  • Moving the variables could be done with a position number or by drag and drop.
@BeateJ BeateJ added the enhancement New feature or request label Jun 19, 2023
@BeateJ BeateJ added this to Backlog Jun 19, 2023
@BeateJ BeateJ moved this to Todo in Backlog Jun 19, 2023
@AyaMoussa AyaMoussa self-assigned this Nov 29, 2024
@AyaMoussa
Copy link
Collaborator

AyaMoussa commented Dec 2, 2024

Solved in blockly. Pull request can be found in Pull requests

@AyaMoussa AyaMoussa removed this from Backlog Dec 2, 2024
@AyaMoussa AyaMoussa moved this from Todo to To Review in Release 5.2.25 Dec 2, 2024
bjost2s added a commit to OpenRoberta/blockly that referenced this issue Dec 14, 2024
…blocks to be able to change their positioning and adopt the callers accordingly
bjost2s added a commit to OpenRoberta/blockly that referenced this issue Dec 15, 2024
…ete variables from orphan variable declarations)
bjost2s added a commit to OpenRoberta/blockly that referenced this issue Dec 15, 2024
bjost2s added a commit that referenced this issue Dec 15, 2024
…e their positioning and adopt the callers accordingly
@bjost2s
Copy link
Contributor

bjost2s commented Dec 15, 2024

Please test this fix in detail, there are a lot of changes that could (hopefully not) break the xml

@rbudde
Copy link
Contributor

rbudde commented Dec 16, 2024

I tested a lot. Everything looks fine except the following error:

  • create a function with param p1 and p2
  • use this in some function calls
  • the generated target code is fine (first image)
  • move p2 to the first position
  • regenerate the target code (this includes a server round-trip)
  • the sequence of parameters in blockly is updated correctly
  • in the code generated the sequence is wrong (second image).
  • btw: if you regenerate the target code a second time, everything is fine again. Strange :-<

Image
Image

bjost2s added a commit to OpenRoberta/blockly that referenced this issue Dec 18, 2024
@rbudde
Copy link
Contributor

rbudde commented Dec 19, 2024

works as expected

@rbudde rbudde closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from To Review to Done in Release 5.2.25 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants