Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in FastLookup.php undefined method getDomain #29

Open
kikminev opened this issue Aug 16, 2016 · 1 comment
Open

error in FastLookup.php undefined method getDomain #29

kikminev opened this issue Aug 16, 2016 · 1 comment

Comments

@kikminev
Copy link

In opensrs\opensrs\FastLookup.php on line 131 there is a call to $this->getDomain(), which is not defined. It is defined in opensrs/Base.php

@kikminev
Copy link
Author

kikminev commented Aug 16, 2016

Actually, after looking at the Base.php I see that $datObject->data->domain passed to Fastlookup->send is similar to the undefined $this->getDomain(). So In order to test it I changed it in Fastlookup->send

public function send($datObject, $tlds = array()) { $result = $this->checkDomainBunch($datObject->data->domain, $tlds);
// Results
$this->resultFullRaw = $result;
$this->resultRaw = $result;
$this->resultFullFormatted = $this->convertArray2Formatted($this->_formatHolder, $this->resultFullRaw);
$this->resultFormatted = $this->convertArray2Formatted($this->_formatHolder, $this->resultRaw);

}

I also needed to change $_formatHolder to protected(from private) in the child FastDomainLookup.php otherwise it throws an error. Anyway I didn't find another way to fix it. Seems to me that it was never working by looking at the commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant