fix pre release updater and cli uri parser

OpenShock · Nov 23, 2024 · 0e94bee · 0e94bee
1 parent ad72c6e
commit 0e94bee
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/ShockOsc/Cli/MauiCliOptions.cs b/ShockOsc/Cli/MauiCliOptions.cs
@@ -8,5 +8,5 @@ public sealed class MauiCliOptions : CliOptions
     public required bool Console { get; init; }
 
     [Option("uri", Required = false, HelpText = "Custom URI for callbacks")]
-    public required string Uri { get; init; }
+    public required string? Uri { get; init; }
 }
diff --git a/ShockOsc/Platforms/Windows/WindowsEntryPoint.cs b/ShockOsc/Platforms/Windows/WindowsEntryPoint.cs
@@ -53,14 +53,13 @@ private static void Start(MauiCliOptions config)
         {
             using var pipeClientStream = new NamedPipeClientStream(".", "OpenShock.ShockOsc", PipeDirection.Out);
             pipeClientStream.Connect(500);
-
-            var parsedUri = UriParser.Parse(config.Uri);
-
+
             using var writer = new StreamWriter(pipeClientStream);
             writer.AutoFlush = true;
 
             if (!string.IsNullOrEmpty(config.Uri))
             {
+                var parsedUri = UriParser.Parse(config.Uri);
                 var pipeMessage = parsedUri.Type switch
                 {
                     UriParameterType.Show => new PipeMessage { Type = PipeMessageType.Show },

diff --git a/ShockOsc/Services/Updater.cs b/ShockOsc/Services/Updater.cs
@@ -126,8 +126,8 @@ await JsonSerializer.DeserializeAsync<IEnumerable<GithubReleaseResponse>>(
 
             listOfValid.Add((release, version));
         }
-
-        (GithubReleaseResponse, SemVersion)? newestPreRelease = listOfValid.OrderByDescending(x => x.Item2).FirstOrDefault();
+        
+        (GithubReleaseResponse, SemVersion)? newestPreRelease = listOfValid.OrderByDescending(x => x.Item2, SemVersion.PrecedenceComparer).FirstOrDefault();
         var latestRelease = await GetLatestRelease();
         if (newestPreRelease == null && latestRelease == null)
         {