ci: Put environment secret variable on step level instead of job level

OpenShock · Oct 6, 2023 · 81efe68 · 81efe68
1 parent 3b394be
commit 81efe68
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/ci-develop.yml b/.github/workflows/ci-develop.yml
@@ -108,11 +108,10 @@ jobs:
     runs-on: ubuntu-latest
     needs: containerize
     if: ${{ github.ref_type == 'branch' && github.ref_protected && github.event_name != 'pull_request' }}
-    env:
-      WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
 
     steps:
       - name: Call deployment webhook
+        env:
+          WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
         run: |
-          curl -X HEAD -d "" ${{ env.WEBHOOK_URL }}
-
+          curl -X HEAD -d "" $WEBHOOK_URL
diff --git a/.github/workflows/ci-master.yml b/.github/workflows/ci-master.yml
@@ -111,10 +111,10 @@ jobs:
     runs-on: ubuntu-latest
     needs: containerize
     if: ${{ github.ref_type == 'branch' && github.ref_protected && github.event_name != 'pull_request' }}
-    env:
-      WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
 
     steps:
       - name: Call deployment webhook
+        env:
+          WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
         run: |
-          curl -X HEAD -d "" ${{ env.WEBHOOK_URL }}
+          curl -X HEAD -d "" $WEBHOOK_URL