Add 'allowCreate: false' to sp config and downgraded smalify (#343)

* samlify sets an empty string as default for AllowCreate in authn request which leads to errors in some IdPs. * samlify in 2.8.11 does not recognize the AllowCreate attribute so it is downgraded to 2.8.10 (tngan/samlify#538) Co-authored-by: peb-adr <[email protected]>
OpenSlides · Apr 12, 2024 · 07ba21b · 07ba21b
1 parent 48c5b4a
commit 07ba21b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 21 deletions.
diff --git a/auth/package-lock.json b/auth/package-lock.json
diff --git a/auth/package.json b/auth/package.json
@@ -72,7 +72,7 @@
         "jsonwebtoken": "^9.0.2",
         "response-time": "^2.3.2",
         "rest-app": "^1.0.0-alpha.9",
-        "samlify": "^2.8.11",
+        "samlify": "2.8.10",
         "tslib": "^2.6.2"
     }
 }
diff --git a/auth/src/express/controllers/saml-controller.ts b/auth/src/express/controllers/saml-controller.ts
@@ -197,7 +197,8 @@ export class SamlController {
         });
         return samlify.ServiceProvider({
             metadata: (await this.getSamlSettings()).saml_metadata_sp,
-            privateKey: (await this.getSamlSettings()).saml_private_key
+            privateKey: (await this.getSamlSettings()).saml_private_key,
+            allowCreate: false
         });
     }