Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup models.yml #1648

Open
jsangmeister opened this issue Feb 23, 2023 · 3 comments
Open

Cleanup models.yml #1648

jsangmeister opened this issue Feb 23, 2023 · 3 comments
Labels
clean up needs discussion waiting Waiting for some other PR/feature; more details in comments
Milestone

Comments

@jsangmeister
Copy link
Contributor

We should introduce a formatter for the models.yml. Currently, the order of the attributes of the fields is non-coherent, as well as whether certain attributes are set or not in the default case.

@jsangmeister
Copy link
Contributor Author

We need to define a common order of attributes for this in which they should appear for all fields.

@r-peschke
Copy link
Member

We should introduce a formatter for the models.yml. Currently, the order of the attributes of the fields is non-coherent, as well as whether certain attributes are set or not in the default case.

Yes, but we should wait with re-organization until we have a stabel models.yml again. For now it's better we do not change the sequence, because it will be fairly more complicated to compare a model.yml with and without template fields, because we changed a lot and renamed a lot of fields.

@jsangmeister
Copy link
Contributor Author

I agree, we should of course wait until the template field removal is done.

@jsangmeister jsangmeister added the waiting Waiting for some other PR/feature; more details in comments label Apr 17, 2023
@jsangmeister jsangmeister added waiting Waiting for some other PR/feature; more details in comments and removed waiting Waiting for some other PR/feature; more details in comments labels Apr 25, 2023
@jsangmeister jsangmeister modified the milestones: 4.1, 4.2 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up needs discussion waiting Waiting for some other PR/feature; more details in comments
Projects
None yet
Development

No branches or pull requests

2 participants