Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update motion submission date label visiblity #4428

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Nov 29, 2024

Resolve #4393

@reiterl reiterl added the bug label Nov 29, 2024
@reiterl reiterl added this to the 4.2 milestone Nov 29, 2024
@reiterl reiterl requested a review from Elblinator November 29, 2024 12:54
@reiterl reiterl changed the title Update motion submission date visiblity Update motion submission date label visiblity Nov 29, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motion needs a reload if the permissions from the participant change while the motion is already loaded
This seems to be a missing subscription, the Edit icon has the same problem, but that was already an Issue. If possible please also fix that part. If that's not possible please clarify, so an Issue for that can be created

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Dec 2, 2024
@Elblinator
Copy link
Member

Elblinator commented Dec 3, 2024

Repro:

  • Create a motion
  • Give user A the right to change meta_data from motions
  • In a different browser as User A open the motion (you should see the empty submission date -that's correct)
  • As admin take the meta_data permission away
  • As A the submission date stays visible and the edit icon also stays visible
  • Reload the page and both vanish

The submission date (if empty) and the icon should vanish without the need for a reload

@reiterl
Copy link
Member Author

reiterl commented Dec 3, 2024

Changing the permission don't have a instant effect on another browser. This would be a large feature.
Please open another issue for this.

@reiterl reiterl assigned Elblinator and unassigned reiterl Dec 3, 2024
@reiterl reiterl requested a review from Elblinator December 3, 2024 13:00
@Elblinator
Copy link
Member

Given that this behaviour is a bug and only appears/ becomes visible in this PR, this should be fixed in this PR

As far as I can see permissions and what the user is allowed to see has to be loaded and updated in the same manner as e.g. the motion block in the motion detail page

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Dec 5, 2024
@reiterl reiterl assigned Elblinator and unassigned reiterl Dec 6, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 6, 2024

Added a change to the permission check of this component.

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Dec 12, 2024
@reiterl reiterl requested a review from Elblinator December 12, 2024 10:46
@reiterl reiterl assigned Elblinator and unassigned reiterl Dec 12, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 12, 2024

@Elblinator I followed your suggestion and updated the perms in the timestamp component.

@Elblinator Elblinator merged commit 94082e0 into OpenSlides:main Dec 12, 2024
3 checks passed
@reiterl reiterl deleted the 4393-motion-submission-date-hide branch December 12, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion > metadata > submission date: even without date the heading is visible for 'normal' users
2 participants