Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in Console in motion-detail #4416

Open
Elblinator opened this issue Nov 27, 2024 · 3 comments
Open

Fix Error in Console in motion-detail #4416

Elblinator opened this issue Nov 27, 2024 · 3 comments
Labels
bug needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented Nov 27, 2024

Describe the bug
If the meeting's language is not english and a motion-detail page is reloaded then there is running an Error through the console

How to Reproduce

  1. Create a meeting in the language German (or non English language)
  2. Navigate into the meeting
  3. Create a motion
  4. On the motion-detail page reload the page
  5. Following Error is running through the console
motion-view.component.ts:206 ERROR Error: Parameter "key" is required and cannot be empty
    at _TranslateService.instant (ngx-translate-core.mjs:696:13)
    at _MotionViewComponent.setTitle (base.component.ts:97:49)
    at _MotionViewComponent.onMotionUpdated (motion-view.component.ts:234:15)

Expected behavior
What ever is causing this Error should be fixed

@Elblinator Elblinator added the bug label Nov 27, 2024
@Elblinator Elblinator added this to the 4.2 milestone Nov 27, 2024
@Elblinator Elblinator changed the title Fix Error in Console Fix Error in Console in motion-detail Nov 27, 2024
@reiterl reiterl self-assigned this Nov 28, 2024
@reiterl
Copy link
Member

reiterl commented Nov 28, 2024

I cannot reproduce the failure. Tested with German meeting, motion, motion w. amendments.

@reiterl reiterl assigned rrenkert and unassigned reiterl Nov 28, 2024
@reiterl
Copy link
Member

reiterl commented Dec 4, 2024

I cannot reproduce it.
So I looked at the code. I'm not sure why this happen: It seems like the ViewMotion.getTitle() delivers a undefined, null or perhaps empty string. That should not happen, as title is required. Perhaps broken data?

I still needs a way to reproduce this.

@reiterl
Copy link
Member

reiterl commented Dec 4, 2024

I have seen the error message few times with empty spaces in motion view, but not every time. So, I am sure why this happens.

@reiterl reiterl added the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Projects
None yet
Development

No branches or pull requests

3 participants