Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion > Amendments: deletion of bullet point/paragraphs is not recognized as change #4451

Closed
MSoeb opened this issue Dec 4, 2024 · 2 comments · Fixed by #4454
Closed

Motion > Amendments: deletion of bullet point/paragraphs is not recognized as change #4451

MSoeb opened this issue Dec 4, 2024 · 2 comments · Fixed by #4454
Assignees
Labels
bug critical Highest priority: This has to be done first.
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Dec 4, 2024

Describe the bug
If a bullet point or paragraph is completely deleted with a new amendment, this deletion is not recognized as an amendment. After saving, it is displayed that no change has been made. The crucial point is, that amendment which are created in this way show have no changed content and therefor the information of the change is not available anymore.

Here an example for bullet points.

original motion content:
image

view of bullet point before editing:
image

view of bullet point after edit:
image

amendment view after save:
image

How to Reproduce
Steps to reproduce the behavior:

  1. open a meeting
  2. open motions > create a motion with one paragraph and three bullet points
  3. create amendment to the second bullet point and delete the whole content > save
  4. Amendment is now empty.

Expected behavior
If an amendment deletes a bullet point or a paragraph completely, the amendment should be displayed correctly. Specifically, this means that the bullet point or the paragraph is crossed out in red.

This is part of the Meta diff Issue #2956

@MSoeb MSoeb added the bug label Dec 4, 2024
@MSoeb MSoeb added this to the 4.2 milestone Dec 4, 2024
@MSoeb MSoeb changed the title Motion > Amendments: deletion of bullet point is not recognized as change Motion > Amendments: deletion of bullet point/paragraphs is not recognized as change Dec 4, 2024
@MSoeb MSoeb added the high label Dec 4, 2024
@MSoeb
Copy link
Author

MSoeb commented Dec 4, 2024

Changes:

  • extended to paragraphs
  • added high label

@MSoeb MSoeb added critical Highest priority: This has to be done first. and removed high labels Dec 4, 2024
@emanuelschuetze
Copy link
Member

emanuelschuetze commented Dec 5, 2024

I found the problematic pr which caused the error:
#3667

With commit dc4d970 the reported error was introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical Highest priority: This has to be done first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants