Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion > amendment: formatting change in amendment plus original text leads to wrong diff #4452

Open
MSoeb opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Dec 4, 2024

Describe the bug
Part I: If an amendment change also includes a formatting change in amendment and original text, the diff will be wrong displayed. The whole paragraph will be shown as diff not the relevant parts.

Part II: If a motion paragraph includes for example a bold format in two sentences and an amendment is created in the second sentence with an additional word and a change in the bold content, than the diff is wrong displayed. The whole paragraph will be shown as diff.

Part I - Original motion:
image

Part I - Amendment with red marked diff (amendment plus original text):
image

Part I - Outcome view:
image

Part II - Original motion paragraph
image

Part II - changes done in the amendment - changes are red marked:
image

Part II - Outcome:
image

How to Reproduce
Steps to reproduce the behavior:

  1. open a meeting
  2. open motions > create a motion with two paragraphs. Add in the second paragraph a bold formatting of one word in the first and in the second sentence. > save it.
  3. Part I - create an amendment in first paragraph and change one word. mark the new word and an original word in bold. > save diff
  4. Part I - visual should now be broken like in the example above
  5. Part II - create an amendment in second paragraph and change the second sentence as follow: add one new word right before the bold word and add content to the bold word > save diff

Expected behavior
If an amendment contains text and fomat changes, the diff visual should clearly display differences and should not show a change in the whole paragraph.

Important: Bold format is just an example. This problem also occurs for italic, underlined, strikethrough and color changes. This should not happen for all of these format changes. - FYI: I've tested all of this format types with Part I. At least for this, same problems occur.

This issue is part of the Meta Diff issue. #2956

@MSoeb MSoeb added the bug label Dec 4, 2024
@MSoeb MSoeb added this to the 4.3 milestone Dec 4, 2024
@MSoeb MSoeb changed the title Motion > amendment: formatting change in amendmend plus original text leads to wrong diff Motion > amendment: formatting change in amendment plus original text leads to wrong diff Dec 6, 2024
@MSoeb
Copy link
Author

MSoeb commented Dec 6, 2024

  • changed title
  • extended problems with the counterpart of formatting
  • added a new examples
  • changed the expected behavior with additional requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants