-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion > amendment: formatting change in amendment plus original text leads to wrong diff #4452
Comments
17 tasks
MSoeb
changed the title
Motion > amendment: formatting change in amendmend plus original text leads to wrong diff
Motion > amendment: formatting change in amendment plus original text leads to wrong diff
Dec 6, 2024
|
CatoTH
added a commit
to CatoTH/openslides-client
that referenced
this issue
Dec 7, 2024
CatoTH
added a commit
to CatoTH/openslides-client
that referenced
this issue
Dec 7, 2024
#4461 |
Elblinator
pushed a commit
that referenced
this issue
Dec 9, 2024
Elblinator
pushed a commit
that referenced
this issue
Dec 9, 2024
Part of this Issue was fixed and approved |
Hi! I hope this fixes some of the remaining issues? #4479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Part I: If an amendment change also includes a formatting change in amendment and original text, the diff will be wrong displayed. The whole paragraph will be shown as diff not the relevant parts.
Part II: If a motion paragraph includes for example a bold format in two sentences and an amendment is created in the second sentence with an additional word and a change in the bold content, than the diff is wrong displayed. The whole paragraph will be shown as diff.
Part I - Original motion:
Part I - Amendment with red marked diff (amendment plus original text):
Part I - Outcome view:
Part II - Original motion paragraph
Part II - changes done in the amendment - changes are red marked:
Part II - Outcome:
How to Reproduce
Steps to reproduce the behavior:
Expected behavior
If an amendment contains text and fomat changes, the diff visual should clearly display differences and should not show a change in the whole paragraph.
Important: Bold format is just an example. This problem also occurs for italic, underlined, strikethrough and color changes. This should not happen for all of these format changes. - FYI: I've tested all of this format types with Part I. At least for this, same problems occur.
This issue is part of the Meta Diff issue. #2956
The text was updated successfully, but these errors were encountered: