Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README video #59

Merged
merged 5 commits into from
Dec 17, 2024
Merged

README video #59

merged 5 commits into from
Dec 17, 2024

Conversation

hmgaudecker
Copy link
Member

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@hmgaudecker hmgaudecker requested a review from timmens December 16, 2024 12:04
@hmgaudecker
Copy link
Member Author

@timmens, you can ignore almost all changes (just removed a leftover block that was commented out).

In substantive terms, I just replace youtube videos (maybe double-check i added the correct ones) and recorded the readme thing.

timmens
timmens approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@timmens timmens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the video titles correspond to the section name where the video link is posted!

Looks good!

@hmgaudecker hmgaudecker merged commit d6528d7 into main Dec 17, 2024
@hmgaudecker hmgaudecker deleted the tiny-fix branch December 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmens timmens timmens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add screencast on writing readmes
2 participants
@hmgaudecker @timmens