GitHub registry #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/arm64
wederbn
reviewed
Mar 24, 2023
| @@ -2,6 +2,9 @@ | |||
| FROM node:12.7-alpine AS build | |||
| WORKDIR /usr/src/app | |||
| COPY package.json package-lock.json ./ | |||
| RUN apk add --no-cache python2 | |||
There was a problem hiding this comment.
Do we need additional dependencies just because we change the registry?
There was a problem hiding this comment.
That is a fix to be able to build it on the arm64 architecture. I can't remember why it was necessary, because that commit is almost a year old.
wederbn
reviewed
Mar 24, 2023
| with: | ||
| context: . | ||
| platforms: linux/amd64 #,linux/arm64 |
There was a problem hiding this comment.
Any idea what goes wrong for ARM?
There was a problem hiding this comment.
On my machine building for arm64 works, but in the GitHub action it hangs. Maybe their emulation has some problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Docker Hub with the GitHub registry in the GitHub workflow and updates the used GitHub actions.
Needed for OpenTOSCA/opentosca-docker#57