Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub registry #4

Merged
merged 15 commits into from
Mar 24, 2023

Conversation

PhilWun
Copy link

@PhilWun PhilWun commented Mar 23, 2023

This PR

  • replaces Docker Hub with the GitHub registry in the GitHub workflow and updates the used GitHub actions
  • makes the image buildable for the ARM architecture

Needed for OpenTOSCA/opentosca-docker#57

@PhilWun PhilWun requested a review from wederbn March 23, 2023 16:18
with:
repository: sathwik/docker-buildr
path: apache-buildr
- name: Fix dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly do we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile tries to install the newest version of bundler which is incompatible with some other dependencies, that's why we have to change the Dockerfile to install the newest compatible version which is 2.3.26 to fix this error:

ERROR:  Error installing bundler:
The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.3.26. Try installing it with `gem install bundler -v 2.3.26`
bundler requires Ruby version >= 2.6.0. The current ruby version is 2.3.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why using this diff file instead of directly adding it to the Dockerfile?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the Dockerfile is downloaded from their repository and this way we don't have to worry about the license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can´t we use another image as builder then? Looks like a very hacky solution atm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found another image with Apache Buildr and Jruby. I think the cleanest solution would be to include the Dockerfile after all with the modification and the appropriate license statement.

Copy link
Member

@wederbn wederbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wederbn wederbn merged commit e05146d into OpenTOSCA:opentoscaimprovements Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants