-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub registry #4
GitHub registry #4
Conversation
Feature/arm64 image
.github/workflows/docker_image.yml
Outdated
with: | ||
repository: sathwik/docker-buildr | ||
path: apache-buildr | ||
- name: Fix dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dockerfile tries to install the newest version of bundler
which is incompatible with some other dependencies, that's why we have to change the Dockerfile to install the newest compatible version which is 2.3.26 to fix this error:
ERROR: Error installing bundler:
The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.3.26. Try installing it with `gem install bundler -v 2.3.26`
bundler requires Ruby version >= 2.6.0. The current ruby version is 2.3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why using this diff file instead of directly adding it to the Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the Dockerfile is downloaded from their repository and this way we don't have to worry about the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can´t we use another image as builder then? Looks like a very hacky solution atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found another image with Apache Buildr and Jruby. I think the cleanest solution would be to include the Dockerfile after all with the modification and the appropriate license statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR
Needed for OpenTOSCA/opentosca-docker#57