Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Container Registry #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
.env
docker-compose.override.yml
.idea

.secret
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

The fastest way to get started is using [Docker Compose](https://docs.docker.com/compose/):

* **IMPORTANT**: Ensure that you have logged in to the GitHub Container Registry.
* Follow the steps described here: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic
* Create a `.env` file by coping it from `_.env`
* Add your publicly available FQDN or IP address to the `PUBLIC_HOSTNAME` variable in the `.env` file and save it\
(see also [I don't know my public IP](#i-don't-know-my-public-ip))
Expand Down
8 changes: 1 addition & 7 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,8 @@ services:
- '8092:8080'
networks:
- opentosca
engine-ia-jdk8:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove the JDK 8 support completely now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope so 👀

image: opentosca/engine-ia:latest-jdk8
ports:
- '8090:8080'
networks:
- opentosca
engine-ia-jdk17:
image: opentosca/engine-ia:latest-jdk17
image: ghcr.io/opentosca/engine-ia:master
ports:
- '8093:8080'
networks:
Expand Down