Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider echoing settings back to UX on changes #3830

Open
3 tasks done
Mrcubix opened this issue Mar 5, 2025 · 0 comments
Open
3 tasks done

Consider echoing settings back to UX on changes #3830

Mrcubix opened this issue Mar 5, 2025 · 0 comments
Labels
enhancement New feature or request needs-triage This issue or PR has not been properly labeled yet

Comments

@Mrcubix
Copy link
Contributor

Mrcubix commented Mar 5, 2025

Description

To ensure changes made outside of the UX or during the SetSettings are properly synchronized, we should consider just invoking the Daemon's Synchronize event at the end of SetSettings.

Currently it is only done if SetSettings has failed at a specific point.

This would avoid the use of plugins such as UX.Remote which hijacks the UX to synchronize its state.

(Usually plugins can't access the UX, but this take advantage of the fact the UX also load plugins & instantiate them when enabled.)

Acknowledgements

  • I have searched the existing issues and this new issue is not a duplicate of any.
  • I have written a concise and meaningful title.
  • I am on the latest version of OpenTabletDriver.
@Mrcubix Mrcubix added the enhancement New feature or request label Mar 5, 2025
@github-actions github-actions bot added the needs-triage This issue or PR has not been properly labeled yet label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage This issue or PR has not been properly labeled yet
Projects
None yet
Development

No branches or pull requests

1 participant