Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions request.proto
Original file line number Diff line number Diff line change
@@ -1,3 +1,30 @@
enum StreetNetworkMode {
WALK = 0;
BIKE = 1;
CAR = 3;
BIKE_SHARE = 4;
// Car sharing?
// Various car modes: park’n’ride kiss’n’ride…
}


message StreetNetworkParams{
optional StreetNetworkMode origin_mode = 1;
optional StreetNetworkMode destination_mode = 2;
optional int32 max_duration_to_pt = 4;
optional double walking_speed = 3;
optional double bike_speed = 5;
optional double car_speed = 7;
optional double bss_speed = 9;
// Speed sounds ambigious, do you mean:
// 1) slower speak because the bicycle is fragile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the speed depends on the user and the bike (since the bss's bike are generaly heavier than a user's the speed might be different)

// 2) extra time to park or fetch the bicycle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not included in bss_speed but it might be useful to add param for that.

optional string origin_filter = 11;
optional string destination_filter = 12;
// What are these filters?
}


message JourneysRequest {
required string origin = 1;
optional string destination = 2;
Expand Down