-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #2 #6
Open
skinkie
wants to merge
1
commit into
OpenTransport:master
Choose a base branch
from
bliksemlabs:fix_request_issue_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix issue #2 #6
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,30 @@ | ||
enum StreetNetworkMode { | ||
WALK = 0; | ||
BIKE = 1; | ||
CAR = 3; | ||
BIKE_SHARE = 4; | ||
// Car sharing? | ||
// Various car modes: park’n’ride kiss’n’ride… | ||
} | ||
|
||
|
||
message StreetNetworkParams{ | ||
optional StreetNetworkMode origin_mode = 1; | ||
optional StreetNetworkMode destination_mode = 2; | ||
optional int32 max_duration_to_pt = 4; | ||
optional double walking_speed = 3; | ||
optional double bike_speed = 5; | ||
optional double car_speed = 7; | ||
optional double bss_speed = 9; | ||
// Speed sounds ambigious, do you mean: | ||
// 1) slower speak because the bicycle is fragile | ||
// 2) extra time to park or fetch the bicycle | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not included in bss_speed but it might be useful to add param for that. |
||
optional string origin_filter = 11; | ||
optional string destination_filter = 12; | ||
// What are these filters? | ||
} | ||
|
||
|
||
message JourneysRequest { | ||
required string origin = 1; | ||
optional string destination = 2; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the speed depends on the user and the bike (since the bss's bike are generaly heavier than a user's the speed might be different)