This generates a working protocol buffers reply. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot was prunned, I am not directly against the rest, but we must semantically define what clients should provide if there are parent/child relationships. I wonder if it is even possible with newer versions. I mean: Line -> Routes -> Line
| } | ||
|
|
||
| message StopTime { | ||
| optional string arrival_time = 1; |
There was a problem hiding this comment.
shouldn't the arrival_time (an departure) be a posix time ? thus int32
There was a problem hiding this comment.
I greatly agree, but the rationale was to support timezones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot was pruned, I am not directly against the rest, but we must semantically define what clients should
provide if there are parent/child relationships. I wonder if it is even possible with newer versions.
I mean: Line -> Routes -> Line