fix/get_response_not_ponging #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
fix/get_response_not_conversing
branch
from
b8ddf21
to
1eb4975
Compare
emphasize
approved these changes
Oct 12, 2023
we only converse with skills that pong "can_handle": True and therefore dont handle UtteranceState.RESPONSE
JarbasAl
force-pushed
the
fix/get_response_not_conversing
branch
from
a023721
to
37480eb
Compare
JarbasAl
force-pushed
the
fix/get_response_not_conversing
branch
from
031f851
to
e9f6f3c
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #372 +/- ##
==========================================
+ Coverage 60.43% 60.57% +0.13%
==========================================
Files 13 13
Lines 1850 1854 +4
==========================================
+ Hits 1118 1123 +5
+ Misses 732 731 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
emphasize
pushed a commit
to emphasize/ovos-core
that referenced
this pull request
Oct 12, 2023
* fix/get_response_not_conversing we only converse with skills that pong "can_handle": True and therefore dont handle UtteranceState.RESPONSE * use threading.Event * comments + readability * pin older ovos utils until unittests updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only converse with skills that pong "can_handle": True and therefore dont handle UtteranceState.RESPONSE (if skill does not implement self.converse)