feat/stop_per_session #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #391 +/- ##
==========================================
+ Coverage 60.90% 63.11% +2.21%
==========================================
Files 13 14 +1
Lines 1857 2039 +182
==========================================
+ Hits 1131 1287 +156
- Misses 726 752 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-config
that referenced
this pull request
Dec 30, 2023
add stop to the pipeline by default companion to OpenVoiceOS/ovos-core#391
This was referenced Dec 30, 2023
Closed
JarbasAl
force-pushed
the
feat/stop_per_session
branch
from
64e3fc2
to
719544c
Compare
stop is a core functionality that should not be optional, it deserves it's dedicated disambiguation step in the pipeline since it is mission critical this commit deprecates the stop skill and makes it native core functionality stop now behaves like converse, it tries to stop active skills first by order of most recently used, if no skill stops then a global stop bus message is emmited (old / default behaviour) end2end tests
JarbasAl
force-pushed
the
feat/stop_per_session
branch
from
a144952
to
3716d6a
Compare
JarbasAl
added a commit
to OpenVoiceOS/ovos-config
that referenced
this pull request
Jan 19, 2024
* update/stop_pipeline add stop to the pipeline by default companion to OpenVoiceOS/ovos-core#391 * Update mycroft.conf * Update mycroft.conf
6 tasks
JarbasAl
added a commit
to OpenVoiceOS/ovos-config
that referenced
this pull request
Sep 3, 2024
* document transformer plugins (#93) * derprecated util * derprecated util * defaults/transformer_plugins document transformer plugins and enable utterance normalizer by default * Increment Version to 0.0.13a1 * Update Changelog * Create LICENSE * update/stop_pipeline (#94) * update/stop_pipeline add stop to the pipeline by default companion to OpenVoiceOS/ovos-core#391 * Update mycroft.conf * Update mycroft.conf * Increment Version to 0.0.13a2 * Update Changelog * default utterance plugins (#99) enable https://github.com/OpenVoiceOS/ovos-utterance-corrections-plugin and https://github.com/OpenVoiceOS/ovos-utterance-plugin-cancel by default if installed * adjust adapt matcher pipeline defaults (#100) * Increment Version to 0.0.13a3 * Increment Version to 0.0.13a4 * Update Changelog * Update Changelog * Update mycroft.conf (#95) * Increment Version to 0.0.13a5 * Update Changelog * readd low adapt matches (intent pipeline) (#101) * readd low adapt matches * adjust common_qa * adjust pipeline * Increment Version to 0.0.13a6 * Update Changelog * Create dependabot.yml * fix/remove_broken_patch (#107) * fix/remove_broken_patch patch for mycroft-era `Configuration.get` (now `Configuration()`) is broken and causes .get to behave weirdly ``` self.config = dict(Configuration()) # below is False, like in mycroft.conf self.config = Configuration() # below is None ???? self.audio_enabled = self.config.get("enable_old_audioservice") ``` * bad test * signal breaking change ripping out a broken patch that we dont use anywhere, but technically a breaking change. who knows how many places are not actually reading config... bumping to 0.1.0 in case anything depends on the broken behaviour * Update version.py * Increment Version to 0.0.13a7 * Update Changelog * fix: "adapt_medium" before padatious (#110) reprioritize pipeline components * Increment Version to 0.0.13a8 * Update Changelog * improve env vars handling (#54) * Update meta.py improve env vars handling * typo * os.env priority * Update meta.py * Increment Version to 0.0.13a9 * Update Changelog * Update ovos-bus-client requirement from ~=0.0.3 to ~=0.0.8 in /requirements (#106) Updates the requirements on [ovos-bus-client](https://github.com/OpenVoiceOS/ovos-bus-client) to permit the latest version. - [Release notes](https://github.com/OpenVoiceOS/ovos-bus-client/releases) - [Changelog](https://github.com/OpenVoiceOS/ovos-bus-client/blob/dev/CHANGELOG.md) - [Commits](OpenVoiceOS/ovos-bus-client@V0.0.3...V0.0.8) --- updated-dependencies: - dependency-name: ovos-bus-client dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increment Version to 0.0.13a10 * Update Changelog * Update ovos-backend-client requirement from <0.1.0 to <0.2.0 in /requirements (#104) Updates the requirements on [ovos-backend-client](https://github.com/OpenVoiceOS/ovos-backend-client) to permit the latest version. - [Release notes](https://github.com/OpenVoiceOS/ovos-backend-client/releases) - [Changelog](https://github.com/OpenVoiceOS/ovos-backend-client/blob/dev/CHANGELOG.md) - [Commits](OpenVoiceOS/ovos-backend-client@V0.0.1a4...V0.1.0) --- updated-dependencies: - dependency-name: ovos-backend-client dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increment Version to 0.0.13a11 * Update Changelog * Update mycroft.conf (#112) remove unimplemented duck_while_listening, docs for non existing features are misleading change default lang detect plugin to use public servers (no extra deps) disable mpris by default in OCP, as that seems to be the cause of many issues in core 0.0.7 * Increment Version to 0.0.13a12 * Update Changelog * move to vosk (#124) * move to vosk move from pocketsphinx to vosk companion to OpenVoiceOS/ovos-dinkum-listener#113 * Update mycroft.conf * Increment Version to 0.0.13a13 * Update Changelog * feat/ocp_pipeline (#96) * feat/ocp_pipeline * feat/OCP_backends * Update mycroft.conf * Update mycroft.conf * Update mycroft.conf * Update mycroft.conf * "adapt_low", * Update mycroft.conf * Update mycroft.conf * remove deprecated flag got rid of it OpenVoiceOS/ovos-core#491 --------- Co-authored-by: JarbasAi <[email protected]> Co-authored-by: JarbasAI <[email protected]> * Increment Version to 0.0.13a14 * Update Changelog * fix/typo (#126) missing an X in pocketsphinX #124 * Increment Version to 0.0.13a15 * Update Changelog * Update python-dateutil requirement from ~=2.6 to ~=2.9 in /requirements (#115) Updates the requirements on [python-dateutil](https://github.com/dateutil/dateutil) to permit the latest version. - [Release notes](https://github.com/dateutil/dateutil/releases) - [Changelog](https://github.com/dateutil/dateutil/blob/master/NEWS) - [Commits](dateutil/dateutil@2.6.0...2.9.0.post0) --- updated-dependencies: - dependency-name: python-dateutil dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increment Version to 0.0.13a16 * Update Changelog * fix: unbound local var (#127) * fix: resolve unbound local variable Closes #118 * chore: clean up issues identified by linter * revert rename * tidy up workflows * bump pytest * Increment Version to 0.0.13a17 * Update Changelog * better listener defaults (#133) use instant_listen by default, avoids OpenVoiceOS/ovos-dinkum-listener#107 until fixed enabled remove_silence by default, further making the above a better default (as listen sound gets removed by silero vad), safe to do since OpenVoiceOS/ovos-dinkum-listener#122 * Increment Version to 0.0.13a18 * Update Changelog * fix config set (#134) fix #73 fix #59 * Increment Version to 0.0.13a19 * Update Changelog * Update mycroft.conf (#136) * Update mycroft.conf add adapt/padatious default values * Update mycroft.conf * Update mycroft.conf * Update mycroft.conf * Update mycroft.conf * Increment Version to 0.0.13a20 * Update Changelog * feat: add /usr/share as a config location (#128) /usr/share/<application name> is becoming more and more common for applications to store their default configuration in. Either the application itself or distributions can use this location to ship a config that users will not touch, and instead they are expected to overwrite (parts of) the config in /etc/<application name>. This means this config file can be safely updated with new required values without having to worry about overwriting user-made change. This is useful in general but especially in case of immutable distributions who don't touch anything in /etc and /home * Increment Version to 0.0.13a21 * Update Changelog * revert to single thread (#137) use single_thread for padatious by default * Increment Version to 0.0.13a22 * Update Changelog * tweak OCP defaults (#139) default to keyword matching instead of using the new classifier (companion to OpenVoiceOS/ovos-core#502) reduce min_score from 50 to 40 so more results are considered * Increment Version to 0.0.13a23 * Update Changelog * document audio options (#141) * document audio options document some more ovos-audio options * Update mycroft.conf * Increment Version to 0.0.13a24 * Update Changelog * document "common_query" config options (#143) * Increment Version to 0.0.13a25 * Update Changelog * document "fake_barge_in" (#144) document "fake_barge_in" * Increment Version to 0.0.13a26 * Update Changelog * deprecate/ovos_conf (#138) * deprecate/ovos_conf move exclusively to env vars, ovos.conf file is of very limited use, also not a standard pattern and very uncommon in other projects, it just causes confusion to users and distro packagers (i also simply don't like it and don't want to maintain it :P ) * tests * fix test * Increment Version to 0.0.13a27 * Update Changelog * Increment Version to 0.1.0 * Update Changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: JarbasAI <[email protected]> Co-authored-by: JarbasAl <[email protected]> Co-authored-by: Swen Gross <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: NeonJarbas <[email protected]> Co-authored-by: JarbasAi <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: Bart Ribbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop is a core functionality that should not be optional, it deserves it's dedicated disambiguation step in the pipeline since it is mission critical
this commit deprecates the stop skill and makes it native core functionality
stop now behaves like converse, it tries to stop active skills first by order of most recently used, if no skill stops then a global stop bus message is emmited (old / default behaviour)
OpenVoiceOS/OVOS-workshop#169 should go first, then this PR and then OpenVoiceOS/ovos-config#94