-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skills-essential.txt #401
Conversation
update default skills list
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #401 +/- ##
==========================================
+ Coverage 62.72% 63.11% +0.39%
==========================================
Files 14 14
Lines 2039 2039
==========================================
+ Hits 1279 1287 +8
+ Misses 760 752 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rationale for ocp skills? |
maybe a meta package for OCP and GUI? Instead of making it an option with core.
Then users can just install that meta package and have what they need. It keeps the minimal amount in core requirements itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is the OVOS alerts skill ready for prime time? I thought it still had some work to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually had a look at the tests, this would officially break compat with Python 3.7 it looks like, and possibly others (the tests were cancelled before we could see).
Needs translation other than german and that is hard to come by and needs someone who is a heavy user, not only the usual example test. A reason why list todos are recorded one by one (looping get_response) without parsing as this would be a mess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this, it does cut down the "essential" skills for sure. I still think it may be better to have "meta" packages.
I installed the basic core with the "essential" skills. Later, I add a screen and want to add the GUI. I could find the repo ovos-gui-package
clone and install it, and it would provide all of the skills and plugins needed
@@ -0,0 +1,3 @@ | |||
# TODO - publish | |||
# https://github.com/OpenVoiceOS/skill-ovos-dictation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a desktop skill? Could it not be used on a headless device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point - the skill runtime_requirements do specify it doesn't require a GUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think this should be a desktop skill unless I am missing something.
But being commented out, does not apply yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its commented out because its not published, needs automations in the repo
ill merge for now until that is done as it should not block 0.0.8
https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added |
Need to get it on PyPi first |
Not sure it should be included in the defaults. It is a great extra, but I think the default should be kept to a minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment on ovos-skill-dictation, and still not sure on adding ovos-skill-randomness either to the defaults. I really like the idea of keeping things small and getting a skill store going.
@@ -0,0 +1,3 @@ | |||
# TODO - publish | |||
# https://github.com/OpenVoiceOS/skill-ovos-dictation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think this should be a desktop skill unless I am missing something.
But being commented out, does not apply yet
And looking through things, is this needed as a requirement when we don't require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can approve this with the commented skills as is.
update default skills list
should we add a list with OCP skills only?
what about GUI only skills? like homescreen