Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skills-essential.txt #401

Merged
merged 13 commits into from
Feb 24, 2024
Merged

Update skills-essential.txt #401

merged 13 commits into from
Feb 24, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jan 13, 2024

update default skills list

should we add a list with OCP skills only?

what about GUI only skills? like homescreen

update default skills list
@JarbasAl JarbasAl added the packaging dependency updates or packaging changes label Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf8b6b5) 62.72% compared to head (2433741) 63.11%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #401      +/-   ##
==========================================
+ Coverage   62.72%   63.11%   +0.39%     
==========================================
  Files          14       14              
  Lines        2039     2039              
==========================================
+ Hits         1279     1287       +8     
+ Misses        760      752       -8     
Flag Coverage Δ
unittests 63.11% <100.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emphasize
Copy link
Member

emphasize commented Jan 13, 2024

rationale for ocp skills?
I see GUI skills for headless distributions.

@builderjer
Copy link
Member

maybe a meta package for OCP and GUI? Instead of making it an option with core.

ovos-media-packages
ovos-gui-packages

Then users can just install that meta package and have what they need. It keeps the minimal amount in core requirements itself

Copy link

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is the OVOS alerts skill ready for prime time? I thought it still had some work to do

Copy link

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually had a look at the tests, this would officially break compat with Python 3.7 it looks like, and possibly others (the tests were cancelled before we could see).

@emphasize
Copy link
Member

emphasize commented Jan 15, 2024

LGTM, is the OVOS alerts skill ready for prime time? I thought it still had some work to do

Needs translation other than german and that is hard to come by and needs someone who is a heavy user, not only the usual example test.
Everything other than "en_us" (and "de-de" ofc) is autotranslated and bound to failure. But that's the way it is.
Its Adapt intent, so you have more freedom how to form a sentence, but the parser may butcher the event/reminder name.

A reason why list todos are recorded one by one (looping get_response) without parsing as this would be a mess.

Copy link
Member

@builderjer builderjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this, it does cut down the "essential" skills for sure. I still think it may be better to have "meta" packages.

I installed the basic core with the "essential" skills. Later, I add a screen and want to add the GUI. I could find the repo ovos-gui-package clone and install it, and it would provide all of the skills and plugins needed

@@ -0,0 +1,3 @@
# TODO - publish
# https://github.com/OpenVoiceOS/skill-ovos-dictation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a desktop skill? Could it not be used on a headless device?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point - the skill runtime_requirements do specify it doesn't require a GUI

Copy link
Member

@builderjer builderjer Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think this should be a desktop skill unless I am missing something.

But being commented out, does not apply yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its commented out because its not published, needs automations in the repo

ill merge for now until that is done as it should not block 0.0.8

@JarbasAl
Copy link
Member Author

https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added

@mikejgray
Copy link

https://github.com/OpenVoiceOS/skill-ovos-randomness should also be added

Need to get it on PyPi first

@builderjer
Copy link
Member

Not sure it should be included in the defaults. It is a great extra, but I think the default should be kept to a minimum

@JarbasAl JarbasAl mentioned this pull request Feb 22, 2024
Copy link
Member

@builderjer builderjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on ovos-skill-dictation, and still not sure on adding ovos-skill-randomness either to the defaults. I really like the idea of keeping things small and getting a skill store going.

@@ -0,0 +1,3 @@
# TODO - publish
# https://github.com/OpenVoiceOS/skill-ovos-dictation
Copy link
Member

@builderjer builderjer Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think this should be a desktop skill unless I am missing something.

But being commented out, does not apply yet

@builderjer
Copy link
Member

And looking through things, is this needed as a requirement when we don't require precise?

Copy link
Member

@builderjer builderjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve this with the commented skills as is.

@JarbasAl JarbasAl added this to the 0.0.8 milestone Feb 24, 2024
@JarbasAl JarbasAl merged commit 20cb5da into dev Feb 24, 2024
9 of 10 checks passed
@JarbasAl JarbasAl deleted the Update-skills-essential.txt branch February 24, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging dependency updates or packaging changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants