Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valves (including PRV and FCV) treated as open pipes!!! #38

Open
AfricAnand opened this issue Oct 9, 2018 · 5 comments
Open

Valves (including PRV and FCV) treated as open pipes!!! #38

AfricAnand opened this issue Oct 9, 2018 · 5 comments

Comments

@AfricAnand
Copy link

I have a model (too large include in mail) with 200 valves(fcv and prv). Epanet v2.0 solves the hydraulic model with valves operating as expected with non-reversible flow controls. Surprisingly, running the model with the Epanet3 library resorts to valves behaving as open pipes/links with reversible flows!!

Is this a feature in the new Epanet 3 library?

@LRossman
Copy link
Collaborator

LRossman commented Oct 9, 2018

EPANET-dev is still a work in progress, so it may not provide reliable results for all networks just yet. It isn't supposed to change the way that PRVs behave from that of EPANET 2. Perhaps @AfricAnand could post your network to a file sharing service (like Box or Google Drive) so that it could be used for future testing of the new code as it undergoes further development.

@wqycg
Copy link

wqycg commented Nov 21, 2018

@LRossman The new problem is still focused on the valve(TCV this time). Epanet-dev results in a wide range of negative pressure on a model with 6000+ TCVs. However, there is no negative pressure in Epanet2. Should I trust Epanet2 if they lead to different results ?

@LRossman
Copy link
Collaborator

@wqyuyu please see my earlier comment regarding the current status of EPANET-dev. One feature it does have is that it reports the largest error in satisfying the head loss equation for all links as well as the largest flow continuity error for all nodes. That way you can tell how well a given solution satisfies the governing hydraulic conservation of mass and energy equations. EPANET 2 does not report this.

@wqycg
Copy link

wqycg commented Nov 22, 2018

@LRossman Thanks a lot. There are four limits in source code.
bool GGASolver::hasConverged() { return ( hydBalance.maxHeadErr < headErrLimit ) && ( hydBalance.maxFlowErr < flowErrLimit ) && ( hydBalance.maxFlowChange < flowChangeLimit ) && ( hydBalance.totalFlowChange < flowRatioLimit ); }
It indicates the errors as you mentioned. According to the strict limits, maybe I should trust Epanet-dev and check the results with Epanet2. However,I can't help but doubt the uniqueness of the solution.

@wqycg
Copy link

wqycg commented Nov 25, 2018

@LRossman I have found the reason. In Epanet-dev, there is a default minor loss coefficient which does not exist in Epanet2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants