Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify should_panic messages on tests #1139

Open
ggonzalez94 opened this issue Sep 9, 2024 · 0 comments
Open

Simplify should_panic messages on tests #1139

ggonzalez94 opened this issue Sep 9, 2024 · 0 comments
Milestone

Comments

@ggonzalez94
Copy link
Collaborator

🧐 Motivation
Most of the tests that should panic and use felt252 for the error message are using a tuple of felt252 instead of a single value, even when there's only one value(e.g. #[should_panic(expected: ('Caller is missing role',))]).
The syntax is cluttered and could be simplified(e.g. #[should_panic(expected:'Caller is missing role')])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants