Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SignersInfo packing issue #1299

Open
immrsd opened this issue Jan 13, 2025 · 0 comments
Open

Fix SignersInfo packing issue #1299

immrsd opened this issue Jan 13, 2025 · 0 comments
Assignees
Milestone

Comments

@immrsd
Copy link
Collaborator

immrsd commented Jan 13, 2025

A bug was discovered in the original StorePacking trait impl for SignersInfo: the quorum value was multiplied by an incorrect 2**32 value (0xffffffff instead of 0x100000000). The only case when this incorrect multiplication leads to incorrect unpacking is when signers_count is 0xffffffff (4_294_967_295), causing the quorum to exceed the expected value by one and the signers_count to unpack to 0. If all other use cases the unpacked value equal the one that was packed, since the same constant of 0xffffffff is used for division.

Nevertheless, this issue needs to be addressed.

@immrsd immrsd added this to the 1. current milestone Jan 13, 2025
@immrsd immrsd self-assigned this Jan 13, 2025
@immrsd immrsd moved this to 📋 Backlog in Contracts for Cairo Jan 13, 2025
@immrsd immrsd moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Jan 13, 2025
@immrsd immrsd moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

1 participant