Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ABI usage in relayer and dapp tools #5

Open
spalladino opened this issue Aug 23, 2019 · 1 comment
Open

Review ABI usage in relayer and dapp tools #5

spalladino opened this issue Aug 23, 2019 · 1 comment
Assignees
@frangio

Comments

@spalladino
Copy link
Contributor

spalladino commented Aug 23, 2019 •
edited
Loading

The relayer and dapp tools were developed with a slightly outdated version of the relayhub ABI. Go through all ABI calls and fix them to update them to the latest version of the relayhub.

Also, check whether the balance currently being displayed is correct. In particular, the dapp tool assumes that the recipient implements a getRecipientBalance method, which may not always be the case.

Reach out to Brendan or Chuck if help is needed.
@frangio
Copy link
Contributor

frangio commented Sep 16, 2019

The getRecipientBalance issue has been fixed in #6. The rest of the ABI usage hasn't been reviewed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frangio frangio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spalladino @frangio