feat: unit test external call + msg::sender mocks #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qalisander
changed the title
qalisander
changed the title
qalisander
force-pushed
the
unit-tests/multiple-contract-deployment
branch
from
3838020 to
feb635a
Compare
qalisander
force-pushed
the
unit-tests/multiple-contract-deployment
branch
from
85ce803 to
1ffba32
Compare
Open
3 tasks
…ontract-deployment # Conflicts: # Cargo.lock # Cargo.toml # crates/motsu/README.md
|
Update documentation for the new test case structure |
bidzyyys
reviewed
Jan 21, 2025
3 tasks
0xNeshi
reviewed
Jan 22, 2025
bidzyyys
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Can't wait to have it published on crates.io 🚀
Great job @qalisander!
| .ping(pong.address(), value) | ||
| .expect("should ping successfully"); | ||
|
|
||
| assert_eq!(ponged_value, value + uint!(1_U256)); |
There was a problem hiding this comment.
How about having:
let one = uint!(1_U256);
You have many repetitions.
0xNeshi
reviewed
Jan 23, 2025
Comment on lines
+27
to
33
| //! fn reads_balance( | ||
| //! contract: Contract<Erc20>, | ||
| //! alice: Account, | ||
| //! ) { | ||
| //! let balance = contract.sender(alice).balance_of(Address::ZERO); // Access storage. | ||
| //! assert_eq!(balance, U256::ZERO); | ||
| //! } |
There was a problem hiding this comment.
Suggested change
| //! fn reads_balance( | |
| //! contract: Contract<Erc20>, | |
| //! alice: Account, | |
| //! ) { | |
| //! let balance = contract.sender(alice).balance_of(Address::ZERO); // Access storage. | |
| //! assert_eq!(balance, U256::ZERO); | |
| //! } | |
| //! fn reads_balance( | |
| //! contract: Contract<Erc20>, | |
| //! alice: Account, | |
| //! ) { | |
| //! let balance = contract.sender(alice).balance_of(Address::ZERO); // Access storage. | |
| //! assert_eq!(balance, U256::ZERO); | |
| //! } | |
| //! | |
| //! #[motsu::test] | |
| //! fn approve() { | |
| //! let contract = Contract::<Erc20>::new(); | |
| //! let alice = Account::random(); | |
| //! let bob = Account::random(); | |
| //! let result = contract.sender(alice).approve(bob, U256::from(1)); // Change state. | |
| //! assert!(result.is_ok()); | |
| //! } |
We should add another example documenting a test case that instantiates a contract manually within the test itself, while also showing that they can change state within a test.
This new example works with regular #[test], but we can leave #[motsu::test] if you think it's better.
0xNeshi
reviewed
Jan 31, 2025
0xNeshi
approved these changes
Jan 31, 2025
qalisander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this pr (OpenZeppelin/rust-contracts-stylus#423)
Resolves #8 , Resolves #12, Resolves #5
PR Checklist