Series Management UI/UX Improvements #399
Merged
+129
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferishili
added
bug
enhancement
has behat
bluetom
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fixes #374
fixes #232
fixes #263
What has been solved
Here is the list of current problems with solutions in this PR:
(current) Allowing to delete the default series! => (solved) no more possible and users will be notified with a modal alert!
(current) Throwing error when deleting a series when no default series exists. => (solved) there has to be a default series at all time!
(current) Throwing error when selecting a default series when no default exists. => (solved) No more error! it is exceptionally allowed to make it possible for those courses that does not have default series yet, after that default series cannot be deleted anymore!
(current) No proper alert notifications when an action is succeeeded or failed => (solved) The proper notification messages have been provided also for success requests, in order to make sure users are up-to-date with what happended.
(current) You can import a series over and over again => (solved) you can import a series only once now!
(current) It is possible to re-select already selected default series => (solved) by clicking of the default series radio button, the system will now recognized that this is not a change, therefore it leaves the process.
(current) The table columns mouse cursor (pointer) gives the impression that the column is somehow clickable/editable => (solved) there are now css styling to avoid that and only allow selectable cursors on the set default radio buttons.
(current) The behat tests are taking too long due to using "I should not see '[a text]'" feature step => (solved) Because of providing proper success notifications we now use "I should see '[]'" feature step which is at least 40% faster.
(added) The behat tests are also updated to cover the new concepts such as not allowing duplicated series import or not allowing to delete default series.