Skip to content

Commit

Permalink
fix(api): Don't raise errors when updating the plate reader substate …
Browse files Browse the repository at this point in the history
…+ make referenceWavelength default to None. (#16349)
  • Loading branch information
vegano1 authored Sep 25, 2024
1 parent 4b9487c commit 42aaeba
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class InitializeParams(BaseModel):
)
sampleWavelengths: List[int] = Field(..., description="Sample wavelengths in nm.")
referenceWavelength: Optional[int] = Field(
..., description="Optional reference wavelength in nm."
None, description="Optional reference wavelength in nm."
)


Expand Down
4 changes: 0 additions & 4 deletions api/src/opentrons/protocol_engine/state/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,6 @@ def _add_module_substate( # noqa: C901
):
lid_labware_id = labware.labware_id
break
else:
raise errors.AreaNotInDeckConfigurationError(
"Opentrons Plate Reader lid location not found."
)
self._state.substate_by_module_id[module_id] = AbsorbanceReaderSubState(
module_id=AbsorbanceReaderId(module_id),
configured=False,
Expand Down
7 changes: 1 addition & 6 deletions shared-data/command/schemas/9.json
Original file line number Diff line number Diff line change
Expand Up @@ -4023,12 +4023,7 @@
"type": "integer"
}
},
"required": [
"moduleId",
"measureMode",
"sampleWavelengths",
"referenceWavelength"
]
"required": ["moduleId", "measureMode", "sampleWavelengths"]
},
"InitializeCreate": {
"title": "InitializeCreate",
Expand Down

0 comments on commit 42aaeba

Please sign in to comment.