Skip to content

Commit

Permalink
fix(app): fix run context not closing on the OT-2 after cancelled run (
Browse files Browse the repository at this point in the history
…#16112)

Closes RQA-3090 and RQA-3062

In #16069, we properly close the run context...for Flexes only. Because we don't do tip status checks on the OT-2 post-run, the initialPipettesWithTipsCount is never populated, so the run never closes. This leads to unexpected behavior, like not being able to calibrate your OT-2 anymore, do normal post-run things, etc.
  • Loading branch information
mjhuff authored Aug 23, 2024
1 parent f7b8c30 commit 56b0101
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,9 @@ export function ProtocolRunHeader({
// TODO(jh, 08-15-24): The enteredER condition is a hack, because errorCommands are only returned when a run is current.
// Ideally the run should not need to be current to view errorCommands.

// Close the run if no tips are attached after running tip check at least once.
// Close the run if no tips are attached after running tip check at least once. Post-run tip checks only occur on the Flex.
// This marks the robot as "not busy" as soon as a run is cancelled if drop tip CTAs are unnecessary.
if (initialPipettesWithTipsCount === 0 && !enteredER) {
if ((initialPipettesWithTipsCount === 0 || !isFlex) && !enteredER) {
closeCurrentRun({
onSettled: () => {
if (isQuickTransfer) {
Expand Down

0 comments on commit 56b0101

Please sign in to comment.