From 56b0101d09acd43415c0325ece15544e5c1a303a Mon Sep 17 00:00:00 2001 From: Jamey Huffnagle Date: Fri, 23 Aug 2024 11:46:36 -0400 Subject: [PATCH] fix(app): fix run context not closing on the OT-2 after cancelled run (#16112) Closes RQA-3090 and RQA-3062 In #16069, we properly close the run context...for Flexes only. Because we don't do tip status checks on the OT-2 post-run, the initialPipettesWithTipsCount is never populated, so the run never closes. This leads to unexpected behavior, like not being able to calibrate your OT-2 anymore, do normal post-run things, etc. --- app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx b/app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx index d7025d00242..14fc596a020 100644 --- a/app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx +++ b/app/src/organisms/Devices/ProtocolRun/ProtocolRunHeader.tsx @@ -309,9 +309,9 @@ export function ProtocolRunHeader({ // TODO(jh, 08-15-24): The enteredER condition is a hack, because errorCommands are only returned when a run is current. // Ideally the run should not need to be current to view errorCommands. - // Close the run if no tips are attached after running tip check at least once. + // Close the run if no tips are attached after running tip check at least once. Post-run tip checks only occur on the Flex. // This marks the robot as "not busy" as soon as a run is cancelled if drop tip CTAs are unnecessary. - if (initialPipettesWithTipsCount === 0 && !enteredER) { + if ((initialPipettesWithTipsCount === 0 || !isFlex) && !enteredER) { closeCurrentRun({ onSettled: () => { if (isQuickTransfer) {