From f3a5d2ed443534e28cf23c2c08ee5960dc7b404d Mon Sep 17 00:00:00 2001
From: ncdiehl11 <ndiehl@opentrons.com>
Date: Thu, 2 May 2024 16:46:23 -0400
Subject: [PATCH] add todo for not passing whole analysis down to CommandText

---
 app/src/organisms/RunPreview/index.tsx | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/src/organisms/RunPreview/index.tsx b/app/src/organisms/RunPreview/index.tsx
index 366851714b4a..4525f8e0cc47 100644
--- a/app/src/organisms/RunPreview/index.tsx
+++ b/app/src/organisms/RunPreview/index.tsx
@@ -83,7 +83,11 @@ export const RunPreviewComponent = (
       ? nullCheckedCommandsFromQuery
       : robotSideAnalysis.commands) ?? []
   // pass relevant data from run rather than analysis so that CommandText utilities can properly hash the entities' IDs
-  const analysis =
+  // TODO (nd:05/02/2024): update name and types for CommandText (and children/utilities) use of analysis. These children
+  // and utilities need only a subset of data provided by analysis, and there should be an overlap of these required data
+  // between a completed analysis and a run record, so we shouldn't pass down a franken-analysis, but rather a new interface
+  // with just the required data coming from the analysis OR the run.
+  const protocolDataFromAnalysisOrRun =
     isRunTerminal && runRecord?.data != null
       ? {
           ...robotSideAnalysis,
@@ -171,7 +175,7 @@ export const RunPreviewComponent = (
                   <CommandIcon command={command} color={iconColor} />
                   <CommandText
                     command={command}
-                    robotSideAnalysis={analysis}
+                    robotSideAnalysis={protocolDataFromAnalysisOrRun}
                     robotType={robotType}
                     color={COLORS.black90}
                   />