Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): add runtime parameters to ChooseProtocolSlideout #14781

Merged
merged 7 commits into from
Apr 2, 2024
Merged

feat(app): add runtime parameters to ChooseProtocolSlideout #14781

merged 7 commits into from
Apr 2, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 2, 2024 •
edited
Loading

closes AUTH-246

Overview

Add RTP functionality to ChooseProtocolSlideout

Test Plan

  • upload an RTP-containing protocol to the app
  • navigate to DeviceDetails page
  • select 'Run a protocol' from overflow menu
  • select an RTP protocol from the populated slideout
  • observe flow exposing RTP parameter input and ability to go back and change protocol
  • note that non-RTP-containing protocols show only one step to 'Proceed to setup'
Screen.Recording.2024-04-02.at.3.25.09.PM.mov

Changelog

  • add RTPs to ChooseProtocolSlideout
  • send RTP overrides to useCreateRunFromProtocol hook

Review requests

authorship devs

Risk assessment

low

@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 2, 2024 19:24
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 2, 2024 19:24
@ncdiehl11 ncdiehl11 requested review from b-cooper, koji, shlokamin and jerader and removed request for a team and b-cooper April 2, 2024 19:24
@ncdiehl11 ncdiehl11 requested a review from koji April 2, 2024 19:53
@koji koji self-requested a review April 2, 2024 20:37
koji
koji approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a comment on confirm values button but that can be updated in a following PR since we are waiting for Sue's feedback.

Can we create a ticket to updating test for this?

@ncdiehl11 ncdiehl11 merged commit fc62016 into edge Apr 2, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-rtp-choose-protocol-slideout branch April 2, 2024 21:56
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
feat(app): add runtime parameters to ChooseProtocolSlideout (#14781)
30cb7b1 
closes [AUTH-246](https://opentrons.atlassian.net/browse/AUTH-246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @ncdiehl