fix(protocol-designer) make deck map bigger in deck setup #16947
+33
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
force-pushed
the
pd_deck-map-stuff
branch
from
8430fa1
to
33223d3
Compare
koji
reviewed
Nov 22, 2024
| @@ -215,15 +215,15 @@ export function zoomInOnCoordinate(props: ZoomInOnCoordinateProps): string { | |||
| const { x, y, deckDef } = props | |||
| const [width, height] = [deckDef.dimensions[0], deckDef.dimensions[1]] | |||
|
|
|||
| const zoomFactor = 0.6 | |||
| const zoomFactor = 0.55 | |||
| const newWidth = width * zoomFactor | |||
| const newHeight = height * zoomFactor | |||
|
|
|||
| // +125 and +50 to get the approximate center of the screen point | |||
There was a problem hiding this comment.
Suggested change
| // +125 and +50 to get the approximate center of the screen point | |
| // +20 and +50 to get the approximate center of the screen point |
koji
reviewed
Nov 22, 2024
| <Flex | ||
| backgroundColor={COLORS.white} | ||
| borderRadius={BORDERS.borderRadius12} | ||
| width="100%" | ||
| height={zoomIn.slot != null ? '75vh' : '70vh'} | ||
| height={tab === 'protocolSteps' ? '65.75vh' : '100%'} |
There was a problem hiding this comment.
nit
PROTOCOL_STEPS_HEIGHT = '65.75vh
koji
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3666
Overview
adjust deck map in deck setup - make it bigger and responsive. Also adjust zooming into a slot to match designs more
Test Plan and Hands on Testing
Test deck setup, zooming into a slot, and protocol steps. Make sure it looks good and works as expected. Test with Flex and ot-2
Changelog
Risk assessment
low