Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix scroll on SelectPipettes screen #16983

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 26, 2024

Overview

Reverts overflow on SelectPipettes screen to OVERFLOW_SCROLL. Also, adds autoscroll to bottom to reveal tiprack selection if obscured.

Test Plan and Hands on Testing

  • create new protocol and land on pipette selection screen
  • add pipette type and volume
  • verify that if container for pipette fields selection sufficient for content height, you are autoscrolled to the bottom of the container upon selecting a volume
Screen.Recording.2024-11-26.at.2.38.42.PM.mov

Changelog

  • add autoscroll
  • revert overflow value

Review requests

see test plan

Risk assessment

low

Reverts overflow on SelectPipettes screen to OVERFLOW_SCROLL. Also, adds autoscroll to bottom to
reveal tiprack selection if obscured.
@ncdiehl11 ncdiehl11 self-assigned this Nov 26, 2024
@ncdiehl11 ncdiehl11 requested a review from koji November 26, 2024 20:26
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 26, 2024 20:29
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 26, 2024 20:29
@koji
Copy link
Contributor

koji commented Nov 26, 2024

@ncdiehl11
I think this change will require to mock scrollIntoView like below.

https://github.com/Opentrons/opentrons/blob/edge/app/src/organisms/ODD/RobotSettingsDashboard/__tests__/TouchScreenSleep.test.tsx

@ncdiehl11
Copy link
Collaborator Author

@ncdiehl11 I think this change will require to mock scrollIntoView like below.

https://github.com/Opentrons/opentrons/blob/edge/app/src/organisms/ODD/RobotSettingsDashboard/__tests__/TouchScreenSleep.test.tsx

Thanks Koji, I just caught this.

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks nick!

@ncdiehl11 ncdiehl11 merged commit ff1df36 into edge Nov 27, 2024
14 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_fix-selectpipettes-scroll branch November 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants