Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating settings of repeatable jobs that are deduplicated #1691

Open
axos88 opened this issue Apr 5, 2020 · 1 comment
Open

Updating settings of repeatable jobs that are deduplicated #1691

axos88 opened this issue Apr 5, 2020 · 1 comment

Comments

@axos88
Copy link

axos88 commented Apr 5, 2020

Description

Repeatable job not updated if the cron schedule is not changed. As far as I understand this is by design so that scheduled jobs are not duplicated when starting up the application.
However other information that is not used for deduplication should be updated, such as the number of completed jobs to keep around.

Minimal, Working Test code to reproduce the issue.

defaultQueue.add('ping', {}, { repeat: { cron: '* * * * *' }, removeOnComplete: 1});

(later)

defaultQueue.add('ping', {}, { repeat: { cron: '* * * * *' }, removeOnComplete: 5});

Expected action: The removeOnComplete should be updated to 5. I assume it is the same case with every other setting.

Current workaround: Remove the job and let the app add it back again.

Bull version

3.13.0

Additional information

@abdatta
Copy link

abdatta commented Jun 10, 2020

Yes, we need this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants