Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the play icon to the component's variant lists #258

Open
B3nz01d opened this issue Oct 25, 2022 · 1 comment
Open

Add the play icon to the component's variant lists #258

B3nz01d opened this issue Oct 25, 2022 · 1 comment
Assignees

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 25, 2022

In the entire app update in the component page, the variant list to include the play icon

@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app Update of the Demo App labels Oct 25, 2022
ludovic35 added a commit that referenced this issue Nov 8, 2022
* Refactor, use same item for variant list entries

* Update changelog file
@B3nz01d
Copy link
Collaborator Author

B3nz01d commented Nov 22, 2022

the Bars-navigation was not updated, but an ongoing action was listed to perform some changes to the page, so it will be added at the same time

@B3nz01d B3nz01d added 👌 OK PO and removed 🔍 triage A new issue that needs to be treated labels Nov 22, 2022
@mccart77 mccart77 removed their assignment Nov 22, 2022
@Tayebsed93 Tayebsed93 removed their assignment Nov 25, 2022
ludovic35 added a commit that referenced this issue Oct 9, 2023
* Remove Imagery and Iconography from GuideLines screen (#115)

* Test dev (#116)

* create app icon release
* TESTFLIGHT : add qualif lane
* remove bundle id comment
* rename lane
* set build_and_upload is private lane
* update bundle id info.plist
* add iconSets for dev and qualif
* remove unused asset
* set dev icon on debug build configuration
* mv qualif app icon
* improve icons
* force reading appfile env value

* 108 ods demo update button page to describe all variants (#118)

Update shaped buttons page to conform to new requirements
Improve button styles, expecially for disabled style
Improve Text Button page

* Update files with release version

* Prepare release version 0.3.0 (#125)

* 46 update typo (#127)

* Update Typography screen presentation

* Update to release 0.4.0 dev

* Update and fix (#140)

* Update Cars detail screen with illustration and new background color (#142)

Co-authored-by: Guillaume Margé <[email protected]>

* Update text of the description in card (#139)

Co-authored-by: Guillaume Margé <[email protected]>

* [DemoApp] #136 Show build number and build type in about screen (#141)

* Add buikld number and build type in about screen

* Review build number presentation

* Rafactoring for internal access

* Reanme bundle access

* Refactor bundle class

* #129 Displays components sorted by name (#146)

* Sorts components list before displaying

* Update change log with right issue number

* Set absolute path for Info.plist update (#147)

* Fix compile issue on qualif (#148)

* Set absolute path for Info.plist update

* Fix compilation error

* Bug fix/130 bug missing component illustrations (#151)

* add BarTab image

* replace Card by Card_1 image

* add TextEditMenu image

* update changelog file

* Feature/124 demo app clean up (#153)

* update thumbnails and remove search tar bar

* rename components to conform to last UI specifications

* #42 - Add font style ID and weight in font list (#152)

* add font style ID and weight in font list

* reorder font list

* update font list layout

* [DemoApp/SDK] #150 Add Chip component (#154)

* First version

* Add doc and finelize

* Update changelog

* Fix selection issue

* Asset refacto and add system icon preview

* Ardjust background and disable state

* Pull request review

* Design/fixes sprint 11 (#162)

* tmp

* wip

* update colors

* changelog

* change radius

* 128 bug slider action on bar tap (#156)

Add ODS Slider

* 155 bug typograpy style addition (#164)

* fix

* done

* done (#165)

* rename editText component to textSelection (#167)

* Feature/36 ods component lists (#169)

* Add Missingfiles

* First version of list items

* WIP: First version, waiting for full deseign

* Refocto to set List in demo app

* Refotor chip and add chip in list page"

* Simplify api

* Add som doc

* Rename parameter

* Update changelog and revert some changes

* Fix two issues (#171)

* Update changelog (#172)

* Prepare release0.4.0 (#174)

* Update files with release version

* Update qualif branch (#176)

* Clean code

* 117 Add documentation introduction (#177)

* Update doc for Typography and colors

* Update changelog and version

* Update Info.plist

revert unwanted update in info.plist

* Update TextSelectionPage.swift

clean code

* Update TextSelectionPage.swift

use headline font style for both

* Update home_content.md

fix typo mistakes

* update text after review

Co-authored-by: Jean-Luc Chevalier <[email protected]>

* Update docs for all components (#179)

* Update docs for all components
* remove baseUrl for jekyll
* Update minimal version of the SDK in doc
* Update structure of site for netlify
* Add config for netlify
* Update doc minimum version ios

* Prepare0.4.1 (#183)

* Update files with release version

* Release 0.4.0 (#175)


* 46 update typo (#127)
* Update Typography screen presentation
* Update and fix (#140)
* Update Cars detail screen with illustration and new background color (#142)
* Update text of the description in card (#139)
* [DemoApp] #136 Show build number and build type in about screen (#141)
* Add buikld number and build type in about screen
* Review build number presentation
* Rafactoring for internal access
* Rename bundle access
* Refactor bundle class
* #129 Displays components sorted by name (#146)
* Sorts components list before displaying
* Update change log with right issue number
* Set absolute path for Info.plist update (#147)
* Fix compile issue on qualif (#148)
* Set absolute path for Info.plist update
* Bug fix/130 bug missing component illustrations (#151)
* add BarTab image
* replace Card by Card_1 image
* add TextEditMenu image
* Feature/124 demo app clean up (#153)
* update thumbnails and remove search tar bar
* rename components to conform to last UI specifications
* #42 - Add font style ID and weight in font list (#152)
* [DemoApp/SDK] #150 Add Chip component (#154)
* Fix selection issue
* Asset refactor and add system icon preview
* Adjust background and disable state
* 128 bug slider action on bar tap (#156)
Add ODS Slider
* 155 bug typograpy style addition (#164)
* rename editText component to textSelection (#167)
* Feature/36 ods component lists (#169)

Co-authored-by: LudovicPinel <[email protected]>
Co-authored-by: Julien GALHAUT <[email protected]>
Co-authored-by: Guillaume Margé <[email protected]>
Co-authored-by: Patrick Boursier <[email protected]>

* Update version 0.4.1

Co-authored-by: Jean-Luc Chevalier <[email protected]>
Co-authored-by: Julien GALHAUT <[email protected]>
Co-authored-by: Guillaume Margé <[email protected]>
Co-authored-by: Patrick Boursier <[email protected]>

* 159 ods guidelines spacing (#168)

* use ODSSpacing in ODSDemo
* clean code FontLists
* Update doc

Co-authored-by: Pinel Ludovic <[email protected]>

* #123 Refactor Card page in demo app to show 3 types of cards (#186)

* Use chip for component card page
* Refactor Card List in demo app to add menu

Co-authored-by: Jean-Luc Chevalier <[email protected]>

* replace capitalized words in CGU (not needed for Legal Notice)

* [DemoApp] Bug #138 Cards - outline button update (#188)

* change button style in card page (demo app) : filled -> bordered

* [DemoApp] Add Navigation Bar component  - 57 (#196)

* add navigation bar page in demo app with 4 variants
* add documentation for navigation bar component (styled)

* Module/Card view : fix bad title name, add missing asset and reduce the number of cards in the demo list (#197)

* 199 sources refactoring (#200)

* Source refactoring
* Remove duplicate assets

* Update ODSChipPicker api and preview (#202)

* Update ODSChipPicker api and preview
* Update documentation

* Update slider for accessibility (#203)

* Update accessibity elements

* replace text selection component by text field (only demo) (#201)

* replace text selection component by text field (only demo)
* use same padding for bottom in all demo pages

* #67 Update color description for Dynamic font accessibility (do not truncate text)  (#206)

* Do not truncate text

* Update CHANGELOG.md

Mistakes

* Add accessibilty header traits for group of colors (#207)

Co-authored-by: Guillaume Margé <[email protected]>

* #76 Allow multiline on labels on the about screen (#208)

* Allow multiline on Text

* Add accessibilty traits

* Update CHANGELOG.md

* Update ColorsList.swift

Co-authored-by: Guillaume Margé <[email protected]>

* Group element and set a short desctiption (#209)

Co-authored-by: Guillaume Margé <[email protected]>

* Remove voice over on the image (#210)

Co-authored-by: Guillaume Margé <[email protected]>

* 181 slider accessibility update (#211)

* Update accessibity elements

* Rename file

* Update change log

* Add accessibility reco

* #72 Update vocalized content on color screen  (#213)

* Update Color screen Vocalization

* #214 Add voice over on typography screen (#215)

* Add voice over onn typography screen

* #216 Add Voice Over on spacings screen (#218)

* Add Voice Over on Spacings screen

* Rename module and update changelog (#220)

* Update change log (#224)

* Update changelog (#225)

* 221 release prod app version in v05 (#227)

 Update version in podspec

* Upgrate version (#234)

* Fix change log and update to next version

* 96 bug components card small cards (#236)

Add Small card component

* Update module name (#239)

* #237 Define a Grid of small cards module and use it in application for components (#238)

* Add grid module and use it in demo application

* 182 feature add small and title first card (#241)

* First version of card with Title First
* Improve Image First
* Add documentation

* #228 Change Chip to switch on List screen for "SecondLineOfText" and "LeadingImage" options (#240)

* Remove chips and add switchs

* fix compilation issue (#244)

* fix issue on SwiftLint version, not compatible with xcode 13.2

* #229 Technical update to use Small and ImageFirst cards in demo app and modules (#245)

* Remove ODSCardView and ODSCardModel

* Fix compile error

* #248 Technical code refactoring for component page presentation (#252)

* First refactoring version

* Componeent page refactoring

* Refactor List component

* 222 update the button page to list the available button types (#256)

* new functional buttons with preview
* refactore demo app using new buttons api
* add documentation in code
* new Button api and documentation

* #249 Add bottom sheet to allow the user to show/hide the subtitle in SmallCard Variant Page (#253)

* Add buttom sheet with associated view and model for options

* #251 Add bottom sheet to allow the user to show/hide the various options in CardImageFirst (#255)

* Add bottom sheet options
* Update bottom sheet spacings

* #250 Add bottom sheet to allow the user to show/hide the various options in CardTitleFirst (#254)

* Update buttom sheet with toggles for options

* Update changelog for 0.6.0 release (#271)

* #113 Add theme management and create Orange and InnovationCup themes (#270)

* First version of architecture for theme management

* Directory Refactoring

* Add missing file

* Add external theme

* Refector the way to mange thme definition

* Firsts version with innovation cup theme

* Fix navigation and tab bars colors

* Refactor coloirs

* Finelize colors for theme

* Finelize colors for theme

* cosmetic

* Update docs and add cosmetics comments in code

* Mistake on doc and remove unusefull code

* Fix doc mistakes on publication

* Fix doc mistakes on publication

* Fix doc mistakes on publication

* Add missing files

* Activate swift lint

* Update to 0.7.0 unreleased version

* Fix mistakes

* Fix compile error

* Fix compile error

* Release 0.7.0 version

* Prepare 0.8.0 version

* #258 Add the play icon to the component's variant lists (#282)

* Refactor, use same item for variant list entries

* Update changelog file

* #267 Update the list of Text fields variants (#283)

* #257 Guidelines - Typography text description updates  (#284)

* #257 Guidelines - Typography text description updates (#285)

* Add missing file

* 289 doc add sdk documentation for bars tab component (#290)

* #51 Add banners component (#288)

* #259 Update the Bar Navigation variant list selection (#291)

* #279 [Bug]: [Accessibility] Module Card collections grid (#292)

* #260 Update the Bar Tab variant list selection (#300)

* #295 Add notice.txt file for orange images usage (#303)

* Add NOTICE.txt file for assets usage
* Update changelog file

* Update Release (#305)

* Update to next verison

* Update default text (#308)

* #266 Update the Slider variant list selection (#310)

new slider version with bottom sheet

* #265 Update the progress indicator variant list selection (#309)

new progress indicator with bottom sheet

* Remove head.html to force the use of jekyll theme head (#320)

* #304 Update Bar tab component illustration in landscape (#321)

* Update screen for landscape 
* Update icons for tab bar item illustration

* #263 Refactor the lists variant list selection (#312)

* Add realistic data
* Update documentation
* Update default selected options in bottomsheet

* Fix compile error

* Fix compile error

* Fix publish error updating fastlane version

* Fix publish error updating fastlane version

* Update changelog to fix 0.9.0 version (#327)

* #319 Manage Tap on Action area 1 of a card (#322)

* Add callback parameter to model and add a tap gesture on area1 to call this callback
* Update changelog file to new version

* Fix and update changelog file (#335)

* Fix and update changelog file (#336)

* #31 Add tool bar component (#330)

* Update changelog file and About component (#337)

* [#33] [#331] Update action on card in demo and remove action from component (#338)

* Update action on card in demo and remove action from component

* Update text dans changelog file (#339)

* [#340] Update Changelog file to fix delivery issue (#341)

* Update Changelog file to fix delivery issue

* Update Changelog file to fix delivery issue

* #324 add a button in navigation bar to select theme (#343)

* Add button in navigation bars

* Add Hot switch warning

* Add new links in About config (#344)

* Fix mistake (#349)

* [#347] Keep the number of expected items when switching item type option (#350)

* Fix using css and update changelog file (#351)

* Prepare delivery (#352)

* Add description in about module (#355)

* #56 Add SideBySide card component (#356)

* #56 Add SideBySide card component (review) (#357)

* #354 Update cards demo using realistic data (#358)

* #317 Use bw assets from innovation cup theme (#359)

* #360 Cards rename cards labels and components (#361)

* #362 Add parameter in CardHorizontal configuration to show/hide divider above buttons (#363)

* Add parameter
* update changelog file

* Fix wording and documentation (#365)

* Release0.11 (#368)

* Release0.11 (V2) (#370)

* Update Changelog file to prepare Release
* Fix changelog file error

* #371 Update about module illustrations with bw image (#372)

* Update asset with B&W
* Update version and changelog file
* Update About config to get the right image

* 313 slider with step 1 value is not well computed (#374)

* Fix, 
* Update DemoApp 
* Update Changelog file
* Update Documentation

* Update changelog file (#379)

* Fix and update changelog file (#380)

* Animate bottomSheet and automatically open it when appears (#382)

* #383 Update build scripts to prepare upload on internal portal (#384)

* #385 Accessibility issues on Slider  (#386)

* Fx adjustable value with voice over and not vocalize values labels
* Add accessibility recommendation

* Update script (#402)

* Update build script (#403)

* Update script

* Update faslane

* #325  Add Bottom Sheet component (#404)

* Prepare release (#405)

* Remove Orange logo from README (#400)

Co-authored-by: LudovicPinel <[email protected]>

* Fix issues templates + `README.md` links (#410)

* #63 ods module about (#417)

* First version of About module with appliation description area

* First version of the module with applicatuon section and share button

* First version of the module with application info and some list items

* Some renaming and add popup on feedback button action

* Add appNews screen

* Make ApplicaitonInformation section configurableq

* Add accessibility statement item

* Add configuration for more Orange apps

* Add Rate the app item

* Add mode apps item and refactor items

* Adjust some wordings and rename associated variables

* Udpate the About module for the about page of the app

* Add icon for Design guidelines item

* Update Application information (version and configration of the sharing)

* Add priority in AboutlistItem

* Update store url

* Update image names and Notice.txt

* Rename default image header and update comments

* Update chagelog and application version

* #419 Reorganize repo and Xcode project (#431)

* Make some refactoring in Xcode project, and update some files with comments and headers
* Update change log and embed it into the app

* #430 Update application icons (#432)

* Update icons for Dev, Qualif and Release versions
* Update Notice.txt (List of images under Orange Copy Right)

* Update assets, update images list and changelog file (#434)

* 422 about integration in the demo app (#436)

* Update: 1.  accessibility statement page, 2. url to apple store for the rate the app in module, 3. share the app text

* Fix content format in CGU and Privacy Policy

* Update changelog file

* 423 bug color token issues (#440)

* Update and add some colors

* Update Innovation Cup colors

* Update changelog

* #441 Add documentation for about module (#442)

* Add documentation for about module
* Update changelog
* Fix mistakes in doc

* Update wording (#443)

* Prepare to 0.13.0 (#444)

* Prepare release 0.13.1 (#447)

* Update AppNews and update the date of publication

* Prepare release 0.13.1

* Update Version in XcodeProj

* Prepare release 0.13.1 (#448)

* Update AppNews and update the date of publication

* Prepare release 0.13.1

* Update Version in XcodeProj

* Upload to version 0.14.0 (#450)

* 451 Add documentation for release process (#453)

* Update with build application process

* Update changelog

* [#451] About module: Review The ShareTheApp content because url is presented twice (#454)

* Remove url from text of description and add a remark in documentation

* Update change log

* 446 Update readme file (#455)

* Update Top level ReadMe and add ReadMe for internal targets

* Add Developer documentation

* Fix disable color for icon button + Cosmetics (#458)

* Udpate the config and changelog file (#460)

* #461 Update odsbanner (#463)

* Update API to set 0, 1 or 2 buttons

* Update option for buttons selection with a picker instead of chip

* Update with Async image

* Update doc

* Update api documentation

* Rename button emphasis (#472)

* Add accessibiliy traits (#474)

* #473 Update banner api to use swiftui elements (#475)

* First version, need to update button style

* Refactor api to use swiftui elements (button, and text)

* Restrict button to text only

* Update banner to use swiftUI element

* Update change log

* #471 Update button api to use SwifTUI buttonStyle  (#476)

* Add button emphasis modifier

* Update Button api to use buttonStyle

* Rename varableWith parameter and update changelog file

* #477 Update Card horizontal API  (#478)

* Update API and update changelog

* Update documentation

* #479 Update CardVerticalHeaderFirst api (#480)

* Update API to use swiftUi elements nad update demo app

* Update changelog

* review: Fix mistakes in comments and doc

* #481 Update CardVertivalImageFirst with swiftUI elements and without model (#482)

* Update CardImageFirst with swiftUI element and without model

* review: fix mistakes

* review: update changelog file

* Update changelog and appnews files (#483)

---------

Co-authored-by: Julien GALHAUT <[email protected]>
Co-authored-by: Jean-Luc Chevalier <[email protected]>
Co-authored-by: Guillaume Margé <[email protected]>
Co-authored-by: Patrick Boursier <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants