From 313ea84d721162893ec8578346f0152d67299fee Mon Sep 17 00:00:00 2001 From: Shaun Edwards Date: Sun, 5 Jan 2014 17:53:39 -0500 Subject: [PATCH 1/2] Initial changes for roslaunch check. Industrial robot simulator currently fails due to roslaunch test issue --- industrial_robot_client/CMakeLists.txt | 11 +++++++++++ industrial_robot_simulator/CMakeLists.txt | 8 ++++++++ 2 files changed, 19 insertions(+) diff --git a/industrial_robot_client/CMakeLists.txt b/industrial_robot_client/CMakeLists.txt index 845421bb..e9e26de8 100644 --- a/industrial_robot_client/CMakeLists.txt +++ b/industrial_robot_client/CMakeLists.txt @@ -157,12 +157,23 @@ target_link_libraries(joint_trajectory_action industrial_robot_client ${catkin_LIBRARIES}) add_dependencies(joint_trajectory_action industrial_robot_client_gencpp) +########## +## Test ## +########## # Testing - Only performed on normal (non byte swapped library) catkin_add_gtest(utest_robot_client test/utest.cpp) target_link_libraries(utest_robot_client industrial_robot_client ${catkin_LIBRARIES}) +# ROS launch testing +## ROS launch test should be enabled when launch parameters are supported, +## see details below: +## robot_interface_streaming.launch: 'robot_ip' +## robot_state_visualize.launch]: 'urdf_path' +## robot_interface_download.launch]: 'robot_ip' +##find_package(roslaunch) +##roslaunch_add_file_check(launch) ############# ## Install ## diff --git a/industrial_robot_simulator/CMakeLists.txt b/industrial_robot_simulator/CMakeLists.txt index 09279ae6..383c28af 100644 --- a/industrial_robot_simulator/CMakeLists.txt +++ b/industrial_robot_simulator/CMakeLists.txt @@ -19,6 +19,14 @@ catkin_package( CATKIN_DEPENDS roscpp std_msgs sensor_msgs control_msgs trajectory_msgs industrial_robot_client ) +########## +## Test ## +########## + +# ROS launch testing +find_package(roslaunch) +roslaunch_add_file_check(launch) + ############# ## Install ## ############# From 2da9025acb156b36b72a6249a73f86088b70fc41 Mon Sep 17 00:00:00 2001 From: Shaun Edwards Date: Mon, 6 Jan 2014 21:53:11 -0500 Subject: [PATCH 2/2] Disabled roslaunch tests, waiting for fix. Source version of roslaunch was tested and passed --- industrial_robot_simulator/CMakeLists.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/industrial_robot_simulator/CMakeLists.txt b/industrial_robot_simulator/CMakeLists.txt index 383c28af..cef7ad24 100644 --- a/industrial_robot_simulator/CMakeLists.txt +++ b/industrial_robot_simulator/CMakeLists.txt @@ -24,8 +24,10 @@ catkin_package( ########## # ROS launch testing -find_package(roslaunch) -roslaunch_add_file_check(launch) +## ROS launch testing should be re-enabled when the roslaunch script is officially +## released (see https://github.com/ros/ros_comm/pull/333) +##find_package(roslaunch) +##roslaunch_add_file_check(launch) ############# ## Install ##