Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous yield events reported in Safe account history #1406

Open
micahalcorn opened this issue May 4, 2023 · 3 comments
Open

Erroneous yield events reported in Safe account history #1406

micahalcorn opened this issue May 4, 2023 · 3 comments
Labels
bug Something isn't working dapp Relating to OUSD.com frontend Works related to frontend OETH OETH related things P1 Large amount of significant user impact, a meaningful feature is broken ui/ux Workd that requires design and product overview

Comments

@micahalcorn
Copy link
Member

micahalcorn commented May 4, 2023 •
edited
Loading

I'm connected to the dapp with a Safe wallet via iOS and WalletConnect. When I open my account history, I see yield even though I have not opted-in. Both our dapp and Etherscan agree that my balance has not increased.

https://www.loom.com/share/293b59d5f321478f8db5cccd5964a5d0

This video also depicts #1404.
@micahalcorn micahalcorn added bug Something isn't working P1 Large amount of significant user impact, a meaningful feature is broken dapp Relating to OUSD.com ui/ux Workd that requires design and product overview OETH OETH related things labels May 4, 2023
@micahalcorn micahalcorn added this to the Sprint 50 milestone May 4, 2023
@micahalcorn micahalcorn moved this from Backlog to To-do in Origin DeFi (OUSD + OETH) May 4, 2023
@micahalcorn micahalcorn removed this from the Sprint 50 milestone May 9, 2023
@HrikB HrikB moved this from To-do to In progress in Origin DeFi (OUSD + OETH) May 23, 2023
@rafaelugolini rafaelugolini added the frontend Works related to frontend label May 23, 2023
@HrikB
Copy link
Contributor

HrikB commented May 25, 2023

The cause of this issue that we assume in the backend that a user/contract is opted in from the beginning so we just return all yield events.

However, I'm not sure how to solve this since rebaseOptIns and rebaseOptOuts don't emit an event and thus, aren't indexed. But the frontend is doing its job properly so I would say we should move this be an analytics issue as opposed to dapp one.

One additional thing, this is also an issue on the ousd dapp.

@HrikB HrikB moved this from In progress to Blocked in Origin DeFi (OUSD + OETH) May 25, 2023
@micahalcorn micahalcorn mentioned this issue Jun 21, 2023
Open
@micahalcorn micahalcorn mentioned this issue Jul 28, 2023
Open
@micahalcorn
Copy link
Member Author

See #1754 💡

@toniocodo
Copy link

@micahalcorn this should not happen on the new OETH app, can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dapp Relating to OUSD.com frontend Works related to frontend OETH OETH related things P1 Large amount of significant user impact, a meaningful feature is broken ui/ux Workd that requires design and product overview
Projects
Origin DeFi (OUSD + OETH)
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
4 participants
@micahalcorn @rafaelugolini @toniocodo @HrikB