Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Calamus intermediaries for Classic and Pre-Classic versions #1

Open
Copetan opened this issue Sep 15, 2023 · 2 comments
Open
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@Copetan
Copy link
Member

Copetan commented Sep 15, 2023

If I understand correctly, the reason why we haven't made Calamus mappings for these versions is due to issues with Stitch parsing obfuscated vs unobfuscated names. Ideas on how to fix this have been mentioned Discord, but they have just been scattered conversations up to now, so hopefully people can use this issue (and the respective issue that should be made on the Stich repository) to discuss about this. This issue will be edited as more information comes up.

@Copetan Copetan added enhancement New feature or request help wanted Extra attention is needed labels Sep 15, 2023
@Copetan Copetan added this to To-do Sep 15, 2023
@Copetan Copetan moved this to Todo in To-do Sep 15, 2023
@SpaceWalkerRS
Copy link
Member

SpaceWalkerRS commented Sep 17, 2023

To give some context on Stitch: it tries to figure out which elements are obfuscated and which aren't, and it will only generate an intermediary name for obfuscated elements. For modern versions this works fine, as the only unobfuscated elements are a) inherited from the JDK or another library b) the main class of the game, and these elements should indeed not get intermediary names. However, it gets tricky for early versions of classic, since they appear to be only partially obfuscated. In previous discussions we agreed that we wanted to generate intermediary names for these elements anyway, but that means we need to update Stitch to ignore obfuscation checks.

@SpaceWalkerRS
Copy link
Member

progress on this: mappings have been generated for gen2 - will keep this open until that's stable

@SpaceWalkerRS SpaceWalkerRS moved this from Todo to In Progress in To-do Apr 2, 2024
@SpaceWalkerRS SpaceWalkerRS self-assigned this Apr 2, 2024
@Copetan Copetan added this to gen2 Jul 29, 2024
@Copetan Copetan moved this to In Progress in gen2 Jul 29, 2024
@Copetan Copetan added this to the gen2 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Status: In Progress
Development

No branches or pull requests

2 participants