-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort mappings #163
Comments
Creating a sorting for the mappings seems like a good idea. My rust code sorts them like follows:
Also relevant is the order in which the things are written out:
It would be nice to get the same sorting order with java. One note by me: For comparing my results with the results of the buildscript, I read, sorted and wrote the output once. Also my code has forced sorting in the actual mappings writer. |
I don't like the idea of sorting fields by descriptor, sorting them by name (with how mojang has proguard configured) seems better, because that's their order withing the classfile sorting by name, then descriptor for class members would be better imo |
the order in which mappings appear in mapping files is not well defined - mappings should be sorted in some way so that the order does not randomly change when working on mappings, blowing up commits
The text was updated successfully, but these errors were encountered: