solidtest: Fix segfault in setExteriorShell test

For the pointer version, The `Polyhedralsurface` takes ownership of the shell. This fixes commit 481cce2.
Oslandia · Oct 25, 2024 · d8a2a53 · d8a2a53
1 parent f29b0d6
commit d8a2a53
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/unit/SFCGAL/SolidTest.cpp b/test/unit/SFCGAL/SolidTest.cpp
@@ -21,6 +21,7 @@
 #include "SFCGAL/Kernel.h"
 
 #include "SFCGAL/Solid.h"
+#include "SFCGAL/PolyhedralSurface.h"
 #include "SFCGAL/TriangulatedSurface.h"
 #include "SFCGAL/io/wkt.h"
 #include "SFCGAL/algorithm/covers.h"
@@ -130,7 +131,7 @@ BOOST_AUTO_TEST_CASE(solidSetExteriorRingTest)
   BOOST_CHECK(!shell1->isEmpty());
   BOOST_CHECK(solid->isEmpty());
 
-  solid->setExteriorShell(shell1);
+  solid->setExteriorShell(dynamic_cast<PolyhedralSurface *>(shell1.get())->clone());
   BOOST_CHECK_EQUAL(solid->numShells(), 1);
   BOOST_CHECK(!solid->isEmpty());
   BOOST_CHECK(algorithm::covers3D(solid->exteriorShell(), *shell1));

diff --git a/test/unit/SFCGAL/capi/sfcgal_cTest.cpp b/test/unit/SFCGAL/capi/sfcgal_cTest.cpp
@@ -468,7 +468,7 @@ BOOST_AUTO_TEST_CASE(testSolidSetExteriorShell)
   std::unique_ptr<Geometry> shell1(io::readWkt(polyhedral1Str));
   BOOST_CHECK(!shell1->isEmpty());
 
-  sfcgal_solid_set_exterior_shell(solid.get(), shell1.get());
+  sfcgal_solid_set_exterior_shell(solid.get(), sfcgal_geometry_clone(shell1.get()));
 
   // check
   BOOST_CHECK(!solid->isEmpty());