Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultFeatureInterpreter.InterpretMultipolygonRelation method is not taking into account members without role #11

Closed
Alexey-Stolyarov opened this issue Jul 15, 2016 · 6 comments
Assignees

Comments

@Alexey-Stolyarov
Copy link

This fact disallows interpret a number of administrative boundaries in most of countries. I think, members without roles should be considered as "outer" (from here: http://wiki.openstreetmap.org/wiki/Relation:multipolygon#Members)

@xivk
Copy link
Contributor

xivk commented Aug 2, 2016

What can you suggest to fix this? The default feature interpreter is a very simple example of what's possible but it may be a good idea to get it to a point where it is as good as possible for current OSM data.

The perfect implementation however would allow for a configurable option without the need to rebuild the code.

@Alexey-Stolyarov
Copy link
Author

As a simple fix I suggest interpret relation as outer if it's not marked as inner. I don't think that this is doable create configurable code for any case of OSM input data. Maybe this is good idea to create DefaultFeatureInterpreter as a pattern, that uses well realized converting methods (like, relations to multipolygon, way to line, node to POI, etc.). Any could extend such interpreter as he need.

@xivk xivk self-assigned this Aug 2, 2016
@xivk
Copy link
Contributor

xivk commented Aug 5, 2016

Can you provide me with an example of a relation that should be interpreted like this? Are you sure there isn't an error on the tagging?

@Alexey-Stolyarov
Copy link
Author

Yes. I'll try find some cases for this issue.

@Alexey-Stolyarov
Copy link
Author

Look at this relation: http://www.openstreetmap.org/relation/114071 and see way #33204842 into it. This relation contains inner, outer, and not specified roles (which should be interpreted as outer, regarding OSM's wiki).

@xivk
Copy link
Contributor

xivk commented Jan 3, 2018

This is now part of #32

@xivk xivk closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants